https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/71228
>From e1e99bdf51d559aa9c96cfd733f12b35e8db7728 Mon Sep 17 00:00:00 2001 From: Alex Langford <alangf...@apple.com> Date: Fri, 3 Nov 2023 13:24:27 -0700 Subject: [PATCH 1/3] [lldb] Deprecate SBBreakpoint::AddName in favor of AddNameWithErrorHandling AddName gives no feedback other than if it succeeded whereas AddNameWithErrorHandling gives you back an SBError object. I would like to mark AddName as deprecated and direct folks to use AddNameWithErorrHandling instead. --- lldb/include/lldb/API/SBBreakpoint.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/include/lldb/API/SBBreakpoint.h b/lldb/include/lldb/API/SBBreakpoint.h index 0bb7c31d74f21f9..c7ef287a5a6f17b 100644 --- a/lldb/include/lldb/API/SBBreakpoint.h +++ b/lldb/include/lldb/API/SBBreakpoint.h @@ -112,6 +112,7 @@ class LLDB_API SBBreakpoint { SBError SetScriptCallbackBody(const char *script_body_text); + LLDB_DEPRECATED("Use AddNameWithErrorHandling instead") bool AddName(const char *new_name); SBError AddNameWithErrorHandling(const char *new_name); >From c8d96df16b669670267e8e257f4005b80d28194b Mon Sep 17 00:00:00 2001 From: Alex Langford <nirvashtz...@gmail.com> Date: Fri, 3 Nov 2023 13:42:16 -0700 Subject: [PATCH 2/3] Update lldb/include/lldb/API/SBBreakpoint.h Co-authored-by: Med Ismail Bennani <ism...@bennani.ma> --- lldb/include/lldb/API/SBBreakpoint.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/include/lldb/API/SBBreakpoint.h b/lldb/include/lldb/API/SBBreakpoint.h index c7ef287a5a6f17b..86ecfc4b2965ef7 100644 --- a/lldb/include/lldb/API/SBBreakpoint.h +++ b/lldb/include/lldb/API/SBBreakpoint.h @@ -112,7 +112,7 @@ class LLDB_API SBBreakpoint { SBError SetScriptCallbackBody(const char *script_body_text); - LLDB_DEPRECATED("Use AddNameWithErrorHandling instead") + LLDB_DEPRECATED_FIXME("Doesn't provide error handling", "AddNameWithErrorHandling") bool AddName(const char *new_name); SBError AddNameWithErrorHandling(const char *new_name); >From d4632e3bb6cfc8fc066f009b7f0a9a72c9fb566a Mon Sep 17 00:00:00 2001 From: Alex Langford <alangf...@apple.com> Date: Fri, 3 Nov 2023 14:18:16 -0700 Subject: [PATCH 3/3] clang-format --- lldb/include/lldb/API/SBBreakpoint.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lldb/include/lldb/API/SBBreakpoint.h b/lldb/include/lldb/API/SBBreakpoint.h index 86ecfc4b2965ef7..e08df3b6d5ab075 100644 --- a/lldb/include/lldb/API/SBBreakpoint.h +++ b/lldb/include/lldb/API/SBBreakpoint.h @@ -112,7 +112,8 @@ class LLDB_API SBBreakpoint { SBError SetScriptCallbackBody(const char *script_body_text); - LLDB_DEPRECATED_FIXME("Doesn't provide error handling", "AddNameWithErrorHandling") + LLDB_DEPRECATED_FIXME("Doesn't provide error handling", + "AddNameWithErrorHandling") bool AddName(const char *new_name); SBError AddNameWithErrorHandling(const char *new_name); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits