================
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
   return false;
 }
 
+bool CompilerType::IsSmartPtrType() const {
+  // These regular expressions cover shared, unique and weak pointers both from
+  // stdlibc++ and libc+++.
----------------
bulbazord wrote:

If it covers both, I would suggest changing the names of the variables to not 
have the word "libcxx" in them. Comments can get out of date or otherwise be 
misleading, this one feels confusing to read through. 

https://github.com/llvm/llvm-project/pull/73472
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to