================
@@ -115,8 +148,23 @@ Status
NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping(
emulator_up->SetWriteMemCallback(&WriteMemoryCallback);
emulator_up->SetWriteRegCallback(&WriteRegisterCallback);
- if (!emulator_up->ReadInstruction())
- return Status("Read instruction failed!");
+ if (!emulator_up->ReadInstruction()) {
----------------
ita-sc wrote:
Yep, you are right: I'm adding an interface to get instruction size, as if it
is not a jump or branch, actually, we do not need to emulate it on engine. As
RISCV have a lot of extensions, even vendor-specific, we can not simply emulate
all of them. I've added a common interface, as it may be helpful for other
architectures, as for new implementations later user will need to implement
only branches and jumps.
https://github.com/llvm/llvm-project/pull/90075
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
