================
@@ -550,7 +588,7 @@ Stream::create(const Directory &StreamDesc, const
object::MinidumpFile &File) {
llvm_unreachable("Unhandled stream kind!");
}
-Expected<Object> Object::create(const object::MinidumpFile &File) {
+Expected<Object> Object::create(object::MinidumpFile &File) {
----------------
Jlalond wrote:
@labath I had to drop the const modifier here in order to cache the
MemoryDescriptor_64 offsets. I thought this would be appropriate given
repetitive linear search in the `Stream::create` for Memory64. I'm not sure if
removing the const modifier is the correct decision and would appreciate your
input.
https://github.com/llvm/llvm-project/pull/101272
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
