================
@@ -136,6 +136,22 @@ static size_t layout(BlobAllocator &File,
MinidumpYAML::ExceptionStream &S) {
return DataEnd;
}
+static size_t layout(BlobAllocator &File, MinidumpYAML::Memory64ListStream &S)
{
+ size_t BaseRVA = File.tell() + sizeof(minidump::Memory64ListHeader);
----------------
clayborg wrote:
Don't use `size_t`, it is 32 bits on 32 bit architectures.
Shouldn't the BaseRVA be:
```
uint64_t BaseRVA = File.tell() + sizeof(minidump::Memory64ListHeader) +
S.Entries.size() * sizeof(minidump:: MemoryDescriptor_64);
if (BaseRVA > UINT32_MAX)
Error!
```
This RVA puts the BaseRVA right after the header and would explain your test
suite issues.
https://github.com/llvm/llvm-project/pull/101272
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
