Dear Junichi-san, thanks for your bug report and patch! My availability is a bit limited at the moment and I will most likely not be able to investigate this further in the next couple of weeks . Could any of the other developers on the mailing list using LTKJava have a look at the bug and patch?
> By the way, I found other problems in the Java LLRP toolkit. I'd like to let > you know about some issues if you would like. > Yes ;) please do so! Christian On Oct 11, 2010, at 10:30 PM, 安田 純一/Junichi YASUDA wrote: > Hi LLRP toolkit developers, > > I'm Junichi in Japan. I'm pleased to e-mail guys first. > > I'm software developer and develop middleware for RW by using LLRP > toolkit(Java > ver1.0.0.6). > > It's wonderful library! > > http://sourceforge.net/projects/llrp-toolkit/ > > > I'm affraid that I found small bugs in Java LLRP toolkit. For exsample, in > LLRPConnection class, orginal source is here. > > org/llrp/ltk/net/LLRPConnection.java: L138 > ---- > session.setAttribute(SYNC_MESSAGE_ANSWER, returnMessageType); > LLRPMessage returnMessage = null; > if (!session.isConnected()){ > if(!reconnect()){//reconnect failed > ---- > > I found that session.setAttribute() was ignored when reconnect() was called. > Because the session instance is re-created by future.getSession() in reconnect > () mehtod. > > so I fix it up to the following. > ---- > LLRPMessage returnMessage = null; > if (!session.isConnected()){ > if(!reconnect()){//reconnect failed > log.info("session is not yet connected"); > endpoint.errorOccured("session is not yet connected"); > return null; > } > } > > // move setAttribute here from above block to avoid > // the risk of overwriting session where SYNC_MESSAGE_ANSWER is already > set > session.setAttribute(SYNC_MESSAGE_ANSWER, returnMessageType); > ---- > > Is it correct fix? If this fix is correct, please it patchs this fix to > orignal > code. > > > By the way, I found other problems in the Java LLRP toolkit. I'd like to let > you know about some issues if you would like. > > > Best Regards, > Junichi > > > -------------------------------------- > Junichi YASUDA > > NEC > Platform Business Unit > IT Software Operations Unit > 3rd IT Software Division > > E-mail : [email protected] > Tel : 044-431-7634 (8-22-67351) > MyLine : 8-22-98299 > -------------------------------------- > > --separa...@[email protected]:<LLRPConnection.diff>------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb_______________________________________________ > llrp-toolkit-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
