hi Junichi,
thanks for the bug reports and patches,
I will look into them,
regards,
Basil
On Thu, Oct 14, 2010 at 10:06 AM, "安田 純一/Junichi YASUDA" <
[email protected]> wrote:
> Hi Christian,
>
> OK, I send some bug reports and patches my co-worker found. These
> patches have made and tested by Ohuchi-san who is my young colleague.
>
> 1. javaCustomParameterTemplate.vm.diff
>
> When I used a custom parameter, I got infinite loop. so Ohuchi-san added
> to increase position number in the Template. (see below)
>
> Exsample
> ---------
> // replace custom with actual type
> #foreach ($custom in $utility.allowedCustom($custom.getName()))
> if (custom.getParameterSubtype().intValue() == $custom$subtypeNr){
> custom = new $custom (custom);
> }
> #end
> +
> + position += tempLength; // modified
> here to
> correctly increment the position of processed bits
> +
> #elseif ($utility.hasType($field,$parameterReference))
> ----------
>
> 2. LLRPConnector.java.diff
>
> In this case a RW was not connected, I found that Mina library made by
> Apache throws RuntimeIOException when LLRP toolkit gets session from a
> future instance.
> RuntimeIOException is non-checked Exception, so I think better to add
> checking of network status between LTKJava and a real RW before calling
> getSession() method.
>
> Exsample
> -----
> ConnectFuture future =
> connector.connect(remoteAddress,handler);
> future.join();// Wait until the connection attempt is
> finished.
> - session = future.getSession();
> +
> + if(future.isConnected()){
> + session = future.getSession();
> + }else{
> + String msg = "failed to connect";
> + throw new
> LLRPConnectionAttemptFailedException(msg);
> + }
>
> -----
>
> I hope that these reports and patches helps you.
>
> Junichi.
>
>
> >
> >Dear Junichi-san,
> >
> >thanks for your bug report and patch! My availability is a bit limited at
> the
> >moment and I will most likely not be able to investigate this further in
> the
> >next couple of weeks . Could any of the other developers on the mailing
> list
> >using LTKJava have a look at the bug and patch?
> >
> >> By the way, I found other problems in the Java LLRP toolkit. I'd like to
> >> let
> >> you know about some issues if you would like.
> >>
> >
> >Yes ;) please do so!
> >
> >Christian
> >
> >
> >On Oct 11, 2010, at 10:30 PM, 安田 純一/Junichi YASUDA wrote:
> >
> >> Hi LLRP toolkit developers,
> >>
> >> I'm Junichi in Japan. I'm pleased to e-mail guys first.
> >>
> >> I'm software developer and develop middleware for RW by using LLRP
> toolkit
> >> (Java
> >> ver1.0.0.6).
> >>
> >> It's wonderful library!
> >>
> >> http://sourceforge.net/projects/llrp-toolkit/
> >>
> >>
> >> I'm affraid that I found small bugs in Java LLRP toolkit. For exsample,
> in
> >> LLRPConnection class, orginal source is here.
> >>
> >> org/llrp/ltk/net/LLRPConnection.java: L138
> >> ----
> >> session.setAttribute(SYNC_MESSAGE_ANSWER, returnMessageType);
> >> LLRPMessage returnMessage = null;
> >> if (!session.isConnected()){
> >> if(!reconnect()){//reconnect failed
> >> ----
> >>
> >> I found that session.setAttribute() was ignored when reconnect() was
> called.
> >> Because the session instance is re-created by future.getSession() in
> >> reconnect
> >> () mehtod.
> >>
> >> so I fix it up to the following.
> >> ----
> >> LLRPMessage returnMessage = null;
> >> if (!session.isConnected()){
> >> if(!reconnect()){//reconnect failed
> >> log.info("session is not yet connected");
> >> endpoint.errorOccured("session is not yet
> connected");
> >> return null;
> >> }
> >> }
> >>
> >> // move setAttribute here from above block to avoid
> >> // the risk of overwriting session where SYNC_MESSAGE_ANSWER is
> already
> >> set
> >> session.setAttribute(SYNC_MESSAGE_ANSWER, returnMessageType);
> >> ----
> >>
> >> Is it correct fix? If this fix is correct, please it patchs this fix to
> >> orignal
> >> code.
> >>
> >>
> >> By the way, I found other problems in the Java LLRP toolkit. I'd like to
> >> let
> >> you know about some issues if you would like.
> >>
> >>
> >> Best Regards,
> >> Junichi
> >>
> >>
> >> --------------------------------------
> >> Junichi YASUDA
> >>
> >> NEC
> >> Platform Business Unit
> >> IT Software Operations Unit
> >> 3rd IT Software Division
> >>
> >> E-mail : [email protected]
> >> Tel : 044-431-7634 (8-22-67351)
> >> MyLine : 8-22-98299
> >> --------------------------------------
> >>
> >> --separa...@[email protected]
> :<LLRPConnection.diff>-------------------
> >> -----------------------------------------------------------
> >> Beautiful is writing same markup. Internet Explorer 9 supports
> >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >> Spend less time writing and rewriting code and more time creating great
> >> experiences on the web. Be a part of the beta today.
> >>
> http://p.sf.net/sfu/beautyoftheweb_________________________________________
> >> ______
> >> llrp-toolkit-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
> >
> >
>
> >-----------------------------------------------------------------------------
> >-
> >Beautiful is writing same markup. Internet Explorer 9 supports
> >standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >Spend less time writing and rewriting code and more time creating great
> >experiences on the web. Be a part of the beta today.
> >http://p.sf.net/sfu/beautyoftheweb
> >_______________________________________________
> >llrp-toolkit-devel mailing list
> >[email protected]
> >https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
>
> --------------------------------------
> Junichi YASUDA
>
> NEC
> Platform Business Unit
> IT Software Operations Unit
> 3rd IT Software Division
>
> E-mail : [email protected]
> Tel : 044-431-7634 (8-22-67351)
> MyLine : 8-22-98299
> --------------------------------------
>
> --separa...@[email protected]:
>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> llrp-toolkit-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
>
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
llrp-toolkit-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
