================
@@ -14,7 +14,7 @@
 namespace llvm {
 
 class AMDGPUWaitSGPRHazardsPass
-    : public OptionalPassInfoMixin<AMDGPUWaitSGPRHazardsPass> {
+    : public RequiredPassInfoMixin<AMDGPUWaitSGPRHazardsPass> {
----------------
perlfu wrote:

This pass is required, but only on GFX11 and GFX12.  It replaces the hazard 
recognizer for this hazard class because the architecture of the standard 
hazard recognizer is in appropriate for addressing these.

Option to disable it exists for performance evaluation and/or tuning small 
kernels.
This was explained during review: 
https://github.com/llvm/llvm-project/pull/118750#discussion_r1912799620

https://github.com/llvm/llvm-project/pull/203511
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to