https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/210333
The `GVNPass::dump` method is not used anywhere. Moreover, there's no `GVNPass` state that corresponds to its parameter type. Even if a `GVNPass::dump` method could be useful, this one wasn't it. >From 67ad2e492b9f7a5ead697bfd8ec1e21aef2973cf Mon Sep 17 00:00:00 2001 From: Momchil Velikov <[email protected]> Date: Tue, 7 Jul 2026 14:33:47 +0000 Subject: [PATCH] [GVN] Remove unused debug helper (NFC) The `GVNPass::dump` method is not used anywhere. Moreover, there's no `GVNPass` state that corresponds to its parameter type. Even if a `GVNPass::dump` method could be useful, this one wasn't it. --- llvm/include/llvm/Transforms/Scalar/GVN.h | 1 - llvm/lib/Transforms/Scalar/GVN.cpp | 11 ----------- 2 files changed, 12 deletions(-) diff --git a/llvm/include/llvm/Transforms/Scalar/GVN.h b/llvm/include/llvm/Transforms/Scalar/GVN.h index ffe07fb2ec7e2..0b9c8dc88fe14 100644 --- a/llvm/include/llvm/Transforms/Scalar/GVN.h +++ b/llvm/include/llvm/Transforms/Scalar/GVN.h @@ -491,7 +491,6 @@ class GVNPass : public OptionalPassInfoMixin<GVNPass> { // Other helper routines. bool processInstruction(Instruction *I); bool processBlock(BasicBlock *BB); - void dump(DenseMap<uint32_t, Value *> &Map) const; bool iterateOnFunction(Function &F); bool performPRE(Function &F); bool performScalarPRE(Instruction *I); diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index ee050d5a3861c..155308f0e7f71 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -934,17 +934,6 @@ void GVNPass::salvageAndRemoveInstruction(Instruction *I) { removeInstruction(I); } -#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) -LLVM_DUMP_METHOD void GVNPass::dump(DenseMap<uint32_t, Value *> &Map) const { - errs() << "{\n"; - for (const auto &[Num, Exp] : Map) { - errs() << Num << "\n"; - Exp->dump(); - } - errs() << "}\n"; -} -#endif - enum class AvailabilityState : char { /// We know the block *is not* fully available. This is a fixpoint. Unavailable = 0, _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
