llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-llvm-transforms Author: Momchil Velikov (momchil-velikov) <details> <summary>Changes</summary> The `GVNPass::dump` method is not used anywhere. Moreover, there's no `GVNPass` state that corresponds to its parameter type. Even if a `GVNPass::dump` method could be useful, this one wasn't it. --- Full diff: https://github.com/llvm/llvm-project/pull/210333.diff 2 Files Affected: - (modified) llvm/include/llvm/Transforms/Scalar/GVN.h (-1) - (modified) llvm/lib/Transforms/Scalar/GVN.cpp (-11) ``````````diff diff --git a/llvm/include/llvm/Transforms/Scalar/GVN.h b/llvm/include/llvm/Transforms/Scalar/GVN.h index ffe07fb2ec7e2..0b9c8dc88fe14 100644 --- a/llvm/include/llvm/Transforms/Scalar/GVN.h +++ b/llvm/include/llvm/Transforms/Scalar/GVN.h @@ -491,7 +491,6 @@ class GVNPass : public OptionalPassInfoMixin<GVNPass> { // Other helper routines. bool processInstruction(Instruction *I); bool processBlock(BasicBlock *BB); - void dump(DenseMap<uint32_t, Value *> &Map) const; bool iterateOnFunction(Function &F); bool performPRE(Function &F); bool performScalarPRE(Instruction *I); diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index ee050d5a3861c..155308f0e7f71 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -934,17 +934,6 @@ void GVNPass::salvageAndRemoveInstruction(Instruction *I) { removeInstruction(I); } -#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) -LLVM_DUMP_METHOD void GVNPass::dump(DenseMap<uint32_t, Value *> &Map) const { - errs() << "{\n"; - for (const auto &[Num, Exp] : Map) { - errs() << Num << "\n"; - Exp->dump(); - } - errs() << "}\n"; -} -#endif - enum class AvailabilityState : char { /// We know the block *is not* fully available. This is a fixpoint. Unavailable = 0, `````````` </details> https://github.com/llvm/llvm-project/pull/210333 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
