Thanks for all of the useful information.
Is this a bug in the ladspa_manager.cpp's calculation of HIGH and LOW?
>From the code, it seems HIGH and LOW should pick values close to the
thresholds, but this obviously isn't working for some plugins.
If it's simply too much work to fix, then I would propose these changes.
This patches 4 presets: Glame High, Glame Low, Butterworth High and
Butterworth Low
I picked a higher pitch of 'concert A7' as a default HPF to be consistant
with 440=concert A, but something like 1KHz or 3Khz may also be desirable
default values.
Thoughts welcome.
Add Lines: 687, File: ladspa_manager.cpp: (Add A7 HPF)
> case LADSPA_HINT_DEFAULT_3520;
> return( 3520.0 );
Add Lines 310, File: ladspa.h:
> /* This default hint indicates the number 3520, or `concert A7`
should be used */
#define LADSPA_HINT_DEFAULT_3520 0x300
Add Lines 342, File: ladspa.h:
> #define LADSPA_IS_HINT_DEFAULT_3520(x) (((x) & LADSPA_HINT_DEFAULT_MASK)
> == LADSPA_HINT_DEFAULT_3520)
Add Line 62, File: basics.h:
> #define DEFAULT_3520 LADSPA_HINT_DEFAULT_3520
Add Line 40, File: ladspa_types.h:
> #define LADSPA_HINT_DEFAULT_3520 0x300
>
Change Line: 244, File: lowpass_iir_1891.c:
> LADSPA_HINT_BOUNDED_BELOW | LADSPA_HINT_BOUNDED_ABOVE |
> LADSPA_HINT_DEFAULT_440 | LADSPA_HINT_SAMPLE_RATE |
> LADSPA_HINT_LOGARITHMIC;
Change Line: 242, File: highpass_iir_1890.c:
> LADSPA_HINT_BOUNDED_BELOW | LADSPA_HINT_BOUNDED_ABOVE |
> LADSPA_HINT_DEFAULT_3520 | LADSPA_HINT_SAMPLE_RATE |
> LADSPA_HINT_LOGARITHMIC;
Change Line 631, File: butterworth_1902.c:
> LADSPA_HINT_BOUNDED_BELOW | LADSPA_HINT_BOUNDED_ABOVE |
> LADSPA_HINT_DEFAULT_440 | LADSPA_HINT_SAMPLE_RATE |
> LADSPA_HINT_LOGARITHMIC;
Change Line 705, File: butterworth_1902.c:
> LADSPA_HINT_BOUNDED_BELOW | LADSPA_HINT_BOUNDED_ABOVE |
> LADSPA_HINT_DEFAULT_3520 | LADSPA_HINT_SAMPLE_RATE |
> LADSPA_HINT_LOGARITHMIC;
-Tres
- [email protected]
On Tue, Feb 18, 2014 at 1:15 PM, perret.yannick <[email protected]>wrote:
> Le 18/02/2014 16:41, Vesa a écrit :
> > On 02/18/2014 04:32 PM, Tres Finocchiaro wrote:
> >>
> >> We also can not improve the default values, as they are given by
> >> the plugins, and we don't have code to fix every single plugin.
> >>
> >>
> >> If we are at the mercy of the plugin developers for changing plugin
> >> defaults
> >
> > Why would we be? All of the LADSPA plugins are open source.
> Yes. Moreover changing the control ports description is not very
> difficult (the init function of the plugins is not very complicated, and
> the ports description is not too complicated too).
>
> Moreover as many LADSPA plugins are not natively compatible with LMMS
> (they use other schemes than 1->1 or 2->2, or the don't have the
> appropriate naming scheme for input/output) I think it make sense to
> have a kind of control on the way they are "inside" :)
>
> For example the vocoder plugin I adapted was an existing one, but it
> can't work with LMMS. BTW LMMS tree includes a set of plugins that - I
> guess - were developped for LMMS or adapted for it.
>
> Regards,
> --
> Y.
> >
> >
> >
> ------------------------------------------------------------------------------
> > Managing the Performance of Cloud-Based Applications
> > Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> > Read the Whitepaper.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
> >
> >
> >
> > _______________________________________________
> > LMMS-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/lmms-devel
> >
>
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
> _______________________________________________
> LMMS-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/lmms-devel
>
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
LMMS-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmms-devel
