Couple of bugs in master branch which should be easy to fix. I'd fix them myself, but I thought this would be a good opportunity for our newer developers to get a bit more familiar with our codebase - especially the core part of it, not just the GUI.
#1 - track muting doesn't work Probably caused by recent changes in NotePlayHandles and AudioPorts. I think this can be fixed in AudioPort, where all the NPH's output is mixed to the AudioPort - add a check if the instrument track that is associated with the AudioPort is muted, and if so, skip the processing of the AudioPort, including its fx chain, and don't write its output to the FxMixer. #2 - adding new instrument tracks while song is playing sometimes causes LMMS to hang Might be a bit trickier, this one I think has to do with threading and thread affinity - might need to look into Qt docs for this one. However, don't let that scare you, it's a great opportunity to learn about Qt here. I suggest looking into TrackContainer for starters. #3 - noise at the end when playing sample previews This should be very easy to fix. Look into SamplePlayHandle - there's some part where the end of the buffer isn't cleared when the sample ends mid-buffer, leaving some random data in the audio buffer. A simple memset in the right place should fix this. I don't think any of these have github issues yet, so please notify here if you want to work on one of these, to prevent duplicate work. First come, first served! ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ LMMS-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmms-devel
