On 21 August 2014 14:24, Ola Liljedahl <ola.liljed...@linaro.org> wrote:
> You are not always setting promiscuous mode on network interfaces in
> ODP/linux-dpdk? Promiscuous mode should only be enabled when the application
> requires it. The l2fwd (is this the DPDK port? "passthrough" would be a
> better name) application could have a command line option which requests
> promiscuous mode on the used network interfaces.
>
Even better. Make sense to me. I'll spin the patch and do the changes
in l2fwd cli interface accordingly.
>
> On 21 August 2014 08:57, Santosh Shukla <santosh.shu...@linaro.org> wrote:
>>
>> Noticed that enabling promiscous mode helps l2fwd application work with
>> pktgen
>> or dpdk-pktgen
>>
>> Suggested-by: Venkatesh Vivekanandan <venkatesh.vivekanan...@linaro.org>
>> Signed-off-by: Santosh Shukla <santosh.shu...@linaro.org>
>> ---
>> platform/linux-dpdk/odp_packet_dpdk.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/platform/linux-dpdk/odp_packet_dpdk.c
>> b/platform/linux-dpdk/odp_packet_dpdk.c
>> index d5c8e80..92edac5 100644
>> --- a/platform/linux-dpdk/odp_packet_dpdk.c
>> +++ b/platform/linux-dpdk/odp_packet_dpdk.c
>> @@ -135,6 +135,9 @@ int setup_pkt_dpdk(pkt_dpdk_t * const pkt_dpdk, const
>> char *netdev,
>> ODP_DBG("dpdk tx queue setup done\n");
>> }
>>
>> + /* Enable promiscous mode */
>> + rte_eth_promiscuous_enable(portid);
>> +
>> /* Start device */
>> ret = rte_eth_dev_start(portid);
>> if (ret < 0)
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
