On 21 August 2014 15:47, Venkatesh Vivekanandan
<venkatesh.vivekanan...@linaro.org> wrote:
>
>
>
> On 21 August 2014 15:16, Ola Liljedahl <ola.liljed...@linaro.org> wrote:
>>
>> This command line option would be interpreted by the application. But the
>> application needs a function for setting an interface (pktio instance) in
>> promiscuous mode. Yet another missing piece of API.
>>
> Yes, we don't have say odp_pktio_promisc_enable/disable(). This is what I
> was talking about in yesterday's call as, we miss a bunch of functions in
> supporting the network interface. I will send out a list of functions that
> we might need.
That list nothing device capability or ethtool Ops :) in general as
discussed in chat with you. Ola, is this what your referring too?
>
>>
>>
>> On 21 August 2014 11:27, Venkatesh Vivekanandan
>> <venkatesh.vivekanan...@linaro.org> wrote:
>>>
>>>
>>>
>>>
>>> On 21 August 2014 14:27, Santosh Shukla <santosh.shu...@linaro.org>
>>> wrote:
>>>>
>>>> On 21 August 2014 14:24, Ola Liljedahl <ola.liljed...@linaro.org> wrote:
>>>> > You are not always setting promiscuous mode on network interfaces in
>>>> > ODP/linux-dpdk? Promiscuous mode should only be enabled when the
>>>> > application
>>>> > requires it. The l2fwd (is this the DPDK port? "passthrough" would be
>>>> > a
>>>> > better name) application could have a command line option which
>>>> > requests
>>>> > promiscuous mode on the used network interfaces.
>>>> >
>>>>
>>>> Even better. Make sense to me. I'll spin the patch and do the changes
>>>> in l2fwd cli interface accordingly.
>>>>
>>> There is no way one can pass the command line parameters to the
>>> implementation currently, once that gets in then we can make it a user
>>> configurable parameter. For now, we don't have a choice other than keeping
>>> them enabled.
>>>
>>>>
>>>> >
>>>> > On 21 August 2014 08:57, Santosh Shukla <santosh.shu...@linaro.org>
>>>> > wrote:
>>>> >>
>>>> >> Noticed that enabling promiscous mode helps l2fwd application work
>>>> >> with
>>>> >> pktgen
>>>> >> or dpdk-pktgen
>>>> >>
>>>> >> Suggested-by: Venkatesh Vivekanandan
>>>> >> <venkatesh.vivekanan...@linaro.org>
>>>> >> Signed-off-by: Santosh Shukla <santosh.shu...@linaro.org>
>>>> >> ---
>>>> >> platform/linux-dpdk/odp_packet_dpdk.c | 3 +++
>>>> >> 1 file changed, 3 insertions(+)
>>>> >>
>>>> >> diff --git a/platform/linux-dpdk/odp_packet_dpdk.c
>>>> >> b/platform/linux-dpdk/odp_packet_dpdk.c
>>>> >> index d5c8e80..92edac5 100644
>>>> >> --- a/platform/linux-dpdk/odp_packet_dpdk.c
>>>> >> +++ b/platform/linux-dpdk/odp_packet_dpdk.c
>>>> >> @@ -135,6 +135,9 @@ int setup_pkt_dpdk(pkt_dpdk_t * const pkt_dpdk,
>>>> >> const
>>>> >> char *netdev,
>>>> >> ODP_DBG("dpdk tx queue setup done\n");
>>>> >> }
>>>> >>
>>>> >> + /* Enable promiscous mode */
>>>> >> + rte_eth_promiscuous_enable(portid);
>>>> >> +
>>>> >> /* Start device */
>>>> >> ret = rte_eth_dev_start(portid);
>>>> >> if (ret < 0)
>>>> >> --
>>>> >> 1.7.9.5
>>>> >>
>>>> >>
>>>> >> _______________________________________________
>>>> >> lng-odp mailing list
>>>> >> lng-odp@lists.linaro.org
>>>> >> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>> >
>>>> >
>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>>
>>
>
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
