Ping On 26 November 2014 at 11:07, Bala Manoharan <bala.manoha...@linaro.org> wrote:
> Hi, > > Pls let me know if there are any additional comments for this patch. > If otherwise please provide reviewed-by > > Regards, > Bala > > On 25 November 2014 03:24, Anders Roxell <anders.rox...@linaro.org> wrote: > >> On 24 November 2014 at 22:45, Bill Fischofer <bill.fischo...@linaro.org> >> wrote: >> > Again, this points out that we need to start merging patches. Otherwise >> > we're going to be spending all our time reworking and rebasing them >> rather >> > than moving onto the next patch. There's just no clean way to avoid >> this >> > with API changes since they tend to get very interdependent as >> applications >> > and tests start using them. >> >> Bill, >> >> We are merging patches, and there is always going to be a looser... >> There will be merge conflicts, that the submitter has to resolve if >> git am --3way don't do the trick. >> >> Cheers, >> Anders >> >> > >> > On Mon, Nov 24, 2014 at 3:37 PM, Maxim Uvarov <maxim.uva...@linaro.org> >> > wrote: >> >> >> >> On 11/25/2014 12:34 AM, Mike Holmes wrote: >> >>> >> >>> This no longer applies, can you rebase it ? >> >> >> >> >> >> git am -3 >> >> >> >> helps? >> >> >> >> >> >> >> >> >> >>> On 21 November 2014 08:30, Bala Manoharan <bala.manoha...@linaro.org> >> >>> wrote: >> >>>> >> >>>> Hi Maxim, >> >>>> >> >>>> As discussed, as per the current API a pktio can exist without >> >>>> initializing >> >>>> the classifier and in that case the packets are sent to the default >> >>>> queue >> >>>> for that pktio. We can test the classifier using the classifier >> example >> >>>> which I am currently working in parallel. >> >>>> >> >>>> Regards, >> >>>> Bala >> >>>> >> >>>> On 21 November 2014 18:18, Maxim Uvarov <maxim.uva...@linaro.org> >> wrote: >> >>>>> >> >>>>> On 11/21/2014 03:32 PM, Bala Manoharan wrote: >> >>>>>> >> >>>>>> Hi Maxim, >> >>>>>> >> >>>>>> Can we have those as separate patches. >> >>>>>> I would like to keep this patch as specific for linking pktio with >> >>>>>> classification. >> >>>>>> I have created this patch from the current odp tip. >> >>>>>> >> >>>>>> Regards, >> >>>>>> Bala >> >>>>>> >> >>>>> My ideas was if we link now then we have workable example/packet >> with >> >>>>> classifier. >> >>>>> And we can check that basic functionality works and you don't forget >> >>>>> init >> >>>>> lock or something >> >>>>> like that. >> >>>>> >> >>>>> Maxim. >> >>>>> >> >>>>>> On 21 November 2014 17:37, Maxim Uvarov <maxim.uva...@linaro.org >> >>>>>> <mailto:maxim.uva...@linaro.org>> wrote: >> >>>>>> >> >>>>>> On 11/21/2014 11:53 AM, Balasubramanian Manoharan wrote: >> >>>>>> >> >>>>>> @@ -163,7 +169,7 @@ odp_pktio_t odp_pktio_open(const char >> >>>>>> *dev, odp_buffer_pool_t pool) >> >>>>>> >> >>>>>> Bala, I sent you patch to change API to odp_pktio_open( *dev, >> >>>>>> cost_t). It should be also included to that patch set. >> >>>>>> >> >>>>>> Thanks, >> >>>>>> Maxim. >> >>>>>> >> >>>>>> _______________________________________________ >> >>>>>> lng-odp mailing list >> >>>>>> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> >>>>>> http://lists.linaro.org/mailman/listinfo/lng-odp >> >>>>>> >> >>>>>> >> >>>> >> >>>> _______________________________________________ >> >>>> lng-odp mailing list >> >>>> lng-odp@lists.linaro.org >> >>>> http://lists.linaro.org/mailman/listinfo/lng-odp >> >>>> >> >>> >> >>> >> >> >> >> >> >> _______________________________________________ >> >> lng-odp mailing list >> >> lng-odp@lists.linaro.org >> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > >> > >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> > http://lists.linaro.org/mailman/listinfo/lng-odp >> > >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp
