Yes, this seem to work on Centos 7 and does not generate a automake warning.

Thanks !

Nicolas

On 05/18/2015 05:45 PM, Maxim Uvarov wrote:
> Nicolas does that work on your Makefile?
>
> -GIT_DESC !=$(top_srcdir)/scripts/git_hash.sh
> +GIT_DESC=`$(top_srcdir)/scripts/git_hash.sh`
>
> Thanks,
> Maxim.
>
> On 05/18/2015 18:32, Maxim Uvarov wrote:
>> Hello Anders,
>>
>> can you please take a look what is portable solution here?
>>
>> Thank you,
>> Maxim.
>>
>> On 05/18/2015 17:52, Nicolas Morey-Chaisemartin wrote:
>>>
>>> On 05/07/2015 02:38 PM, Mike Holmes wrote:
>>>> Signed-off-by: Mike Holmes <mike.hol...@linaro.org>
>>>> +
>>>> +GIT_DESC !=$(top_builddir)/scripts/git_hash.sh
>>> This breaks the build on "older" distrib (Centos 7). It seems the != is 
>>> only available in Make >= 4.0
>>> I replaced it by this:
>>> GIT_DESC  = $(shell $(top_srcdir)/scripts/git_hash.sh)
>>>
>>> This generates a warning but works with older Make versions:
>>> platform/Makefile.inc:15: warning: shell $(top_srcdir: non-POSIX variable 
>>> name
>>> platform/Makefile.inc:15: (probably a GNU make extension)
>>>
>>> I am no Automake expert so I'm not sure what's the cleanest way to handle 
>>> this
>>>
>>> Nicolas
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>
>


_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to