On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg for a
basic socket implementation
But yes, this patch removed a lot of code and a new version would be very quick
to implement (mostly replacing mmsg by msg).
Nicolas
Ok, if nobody else do not complain about that remove then we can remove
it right now. Agree, that it will be easy to implement
if needed.
Maxim.
On 06/30/2015 06:00 PM, Stuart Haslam wrote:
On Tue, Jun 30, 2015 at 06:28:10PM +0300, Maxim Uvarov wrote:
Why it's needed to remove basic socket? Some people use very old
machines mmap and mmsg might be not supported.
Maxim.
It simplifies the implementation - this change removed 127 lines and
avoided having to add another bunch.
There's been a sendmmsg wrapper for the last few months, which removes
the need for support for sendmmsg in glibc/kernel. The limiting factor
is likely to be recvmmsg support, which was added in kernel 2.6.33 and
glibc 2.12. That was true previously anyway, since implementation type
was selected at runtime but the failure would occur at build time, so
there is no change as far as I can tell.
If we want to support versions without recvmmsg in future, we'd be
better off writing a wrapper to that similar to the sendmmsg one.
--
Stuart.
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
