On 07/03/15 16:10, Nicolas Morey-Chaisemartin wrote:
Would you mind using the MMSG implementation if recvmmsg is also defined as a
wrapper around recvmsg (as it is done for sendmmsg)?
This we can factor both implementations but keep legacy working.
Prashant,
I think we need to accept this patch due to it really simplifies
functionality. Probably some things are not clear
and we need to clarify them.
1) this patch does not remove functionality. It remove one of 3 generic
access methods to packets.
2) all raw socket, mmsg, and mmap are 'basic' due to they exist in
default linux kernel and supported by glibc
and you don't need to install any additional packages, libraries and
etc. So it's common generic way to accept
packets. I think we are not going to support old 2.4 kernels.
3) application should not depend on any platfrom specific i/o type. If
it depends then most probably you will be
unable to run that app on other platform without rewriting.
Now it is not clear why mmap() and mmsg() does not work for you? Do you
use very old linux?
Thank you,
Maxim.
On 07/01/2015 02:15 PM, Prashant Upadhyaya wrote:
Hi guys,
I object too. Why would you want to 'remove' a functionality.
The 'basic' socket is a very good lowest common denominator of implementation
across all the machines/linux
And it was anyway a fallback mechanism.
Currently atleast my application depends on it, so guys, please don't remove
the basic socket.
Regards
-Prashant
-----Original Message-----
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim
Uvarov
Sent: Wednesday, July 01, 2015 5:39 PM
To: Nicolas Morey-Chaisemartin; Stuart Haslam
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv2 1/3] linux-generic: pktio: remove basic socket
implementation
On 06/30/15 19:06, Nicolas Morey-Chaisemartin wrote:
I got a little bit mixed up between the msg and mmsg version.
After a quick look, we should be able to fall back to recvmsg/sendmsg
for a basic socket implementation
But yes, this patch removed a lot of code and a new version would be very quick
to implement (mostly replacing mmsg by msg).
Nicolas
Ok, if nobody else do not complain about that remove then we can remove it
right now. Agree, that it will be easy to implement if needed.
Maxim.
On 06/30/2015 06:00 PM, Stuart Haslam wrote:
On Tue, Jun 30, 2015 at 06:28:10PM +0300, Maxim Uvarov wrote:
Why it's needed to remove basic socket? Some people use very old
machines mmap and mmsg might be not supported.
Maxim.
It simplifies the implementation - this change removed 127 lines and
avoided having to add another bunch.
There's been a sendmmsg wrapper for the last few months, which
removes the need for support for sendmmsg in glibc/kernel. The
limiting factor is likely to be recvmmsg support, which was added in
kernel 2.6.33 and glibc 2.12. That was true previously anyway, since
implementation type was selected at runtime but the failure would
occur at build time, so there is no change as far as I can tell.
If we want to support versions without recvmmsg in future, we'd be
better off writing a wrapper to that similar to the sendmmsg one.
--
Stuart.
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
"DISCLAIMER: This message is proprietary to Aricent and is intended solely for the
use of the individual to whom it is addressed. It may contain privileged or confidential
information and should not be circulated or used for any purpose other than for what it
is intended. If you have received this message in error, please notify the originator
immediately. If you are not the intended recipient, you are notified that you are
strictly prohibited from using, copying, altering, or disclosing the contents of this
message. Aricent accepts no responsibility for loss or damage arising from the use of the
information transmitted by this email including damage from virus."
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
