On Tuesday, November 24, 2015, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
> On 11/24/2015 21:31, Anders Roxell wrote: > >> On 2015-11-24 17:26, Maxim Uvarov wrote: >> >>> Merged! >>> >>> Patches were long time in the list for review, passed all validations >>> tests >>> and all comments which >>> we got are fixed. >>> >> I can see a number of problems by putting these patches in. >> > Good finding but unfortunately too late. It became very common now review > patches > only after they were merged :( And probably you missed discussion about > accepting > these patches on last 3 meeting. > > 1. The author is not correctly set! It Should be Barry and not Bill! >> > yes, that comment was some version later and I thought it was fixed. > It would be good to document Barry's contribution. > > Maybe it's reasonable add Easy Chip copyright to > include/odp/api/traffic_mngr.h > with Barry's name? Barry should be listed in all modules. He's the main sign off. Not sure why that wouldn't be picked up. > > 2. Petri has not given his Reviewed-by on the API patch. >> > We all know that this TM api was widely discussed on Sprint. Some minor > changes > can fix later. For not it's not candidate for next release until we > polish it in api-next > branch. Petri gave his verbal review/agreement to merge these to api-next. Agree that should be recorded. > > 3. This breaks a build of 32bit on a 64 bit machine. >> >> Should this really go in? I think we should revert this. >> > That is also serious. Can you please ping me tomorrow during day time? I > switched from my synthetic tests to odp-check > and it did not show any errors. I want to understand what is the > difference between ci odp-check and mine. Check-ODP build-all.sh passes for me. How are we expected to test this? I thought check-odp did that . > Let's discuss that patches again in next arch call. > > Thanks, > Maxim. > > Cheers, >> Anders >> >> Best regards, >>> Maxim. >>> >>> On 11/18/2015 03:16, Bill Fischofer wrote: >>> >>>> Changes in v12 >>>> - Refactor to enable serial apply-and-build >>>> >>>> Changes in v11 >>>> - Squash Parts 2 and 3 to give new Part 2 that can build independently >>>> - Change typedef for hash_table_entry_t to uint64_t for 32-bit support >>>> >>>> Changes in v10 >>>> - Add back ARM definitions for _crc32w() from Alex that got dropped in >>>> v9 >>>> >>>> Note: Checkpatch complains about the _asm() line. Says spaces are >>>> needed but >>>> if spaces are added then complains that spaces are prohibited. Rules >>>> need to >>>> be updated to ignore these sort of constructs. >>>> >>>> Changes in v9 >>>> - Rebase on top of latest queue fixes >>>> >>>> Changes in v8 >>>> - add ARM definition for __crc32w() function (from Alex) >>>> >>>> Changes in v7 (review comments by Maxim) >>>> - Correct architecture ifdefs (use of arch dir in later patch) >>>> - Correct doxygen for queue types >>>> - Change internal APIs that use odp_ prefix to use _odp prefix >>>> - Rebase to latest api-next >>>> >>>> Changes in v6 >>>> - Move documentation of packet colors to main API file >>>> - Add ODP prefix to odp_tm_egress_kind_t enums >>>> >>>> Changes in v5 >>>> - Add include file odp_traffic_mngr_internal.h >>>> - Add support for odp_tm_enq() from packets originating from ordered >>>> queues >>>> >>>> Changes in v4 >>>> - Incorporate API changes suggested by Petri >>>> >>>> Changes in v3 >>>> - Fix checkpatch errors (Bill) >>>> >>>> Changes in v2 >>>> - Full patch submission (Barry) >>>> >>>> Barry Spinney (3): >>>> api: tm: add tm API definitions >>>> linux-generic: tm: implement traffic manager >>>> example: tm: traffic manager example >>>> >>>> configure.ac | 1 + >>>> example/Makefile.am | 2 +- >>>> example/traffic_mgmt/.gitignore | 1 + >>>> example/traffic_mgmt/Makefile.am | 9 + >>>> example/traffic_mgmt/odp_traffic_mgmt.c | 781 ++++++ >>>> include/odp.h | 1 + >>>> include/odp/api/packet.h | 69 + >>>> include/odp/api/traffic_mngr.h | 1611 +++++++++++ >>>> platform/linux-generic/Makefile.am | 13 + >>>> .../linux-generic/include/odp/plat/packet_types.h | 11 + >>>> .../linux-generic/include/odp/plat/queue_types.h | 7 + >>>> .../include/odp/plat/traffic_mngr_types.h | 185 ++ >>>> platform/linux-generic/include/odp/traffic_mngr.h | 35 + >>>> platform/linux-generic/include/odp_internal.h | 2 + >>>> .../include/odp_name_table_internal.h | 61 + >>>> .../linux-generic/include/odp_packet_internal.h | 5 + >>>> .../linux-generic/include/odp_pkt_queue_internal.h | 62 + >>>> .../linux-generic/include/odp_queue_internal.h | 6 + >>>> .../include/odp_sorted_list_internal.h | 78 + >>>> .../include/odp_timer_wheel_internal.h | 68 + >>>> .../include/odp_traffic_mngr_internal.h | 324 +++ >>>> platform/linux-generic/odp_init.c | 5 + >>>> platform/linux-generic/odp_name_table.c | 1371 ++++++++++ >>>> platform/linux-generic/odp_packet_flags.c | 46 +- >>>> platform/linux-generic/odp_pkt_queue.c | 379 +++ >>>> platform/linux-generic/odp_queue.c | 60 + >>>> platform/linux-generic/odp_sorted_list.c | 271 ++ >>>> platform/linux-generic/odp_timer_wheel.c | 907 +++++++ >>>> platform/linux-generic/odp_traffic_mngr.c | 2799 >>>> ++++++++++++++++++++ >>>> 29 files changed, 9168 insertions(+), 2 deletions(-) >>>> create mode 100644 example/traffic_mgmt/.gitignore >>>> create mode 100644 example/traffic_mgmt/Makefile.am >>>> create mode 100644 example/traffic_mgmt/odp_traffic_mgmt.c >>>> create mode 100644 include/odp/api/traffic_mngr.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp/plat/traffic_mngr_types.h >>>> create mode 100644 platform/linux-generic/include/odp/traffic_mngr.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp_name_table_internal.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp_pkt_queue_internal.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp_sorted_list_internal.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp_timer_wheel_internal.h >>>> create mode 100644 >>>> platform/linux-generic/include/odp_traffic_mngr_internal.h >>>> create mode 100644 platform/linux-generic/odp_name_table.c >>>> create mode 100644 platform/linux-generic/odp_pkt_queue.c >>>> create mode 100644 platform/linux-generic/odp_sorted_list.c >>>> create mode 100644 platform/linux-generic/odp_timer_wheel.c >>>> create mode 100644 platform/linux-generic/odp_traffic_mngr.c >>>> >>>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
