On 02/18/16 16:21, Bill Fischofer wrote:
Ok, I'll do a v4 based on all of your review comments. Please advise
when they're complete.
Bill, I think it's complete. Might be it's reasonable to send v4 just
after Petri's patches.
I did not run that tests but I think we can do it after merge there
might be some work needed
to make test work if they expect high packet rate on input.
Maxim.
On Thu, Feb 18, 2016 at 7:14 AM, Maxim Uvarov <maxim.uva...@linaro.org
<mailto:maxim.uva...@linaro.org>> wrote:
On 02/18/16 15:51, Bill Fischofer wrote:
This was just a rebase. I agree we should add a stage. I'll
do that in a separate patch if this one is acceptable. Or
would you prefer to see that added directly here?
If possible that changes should be in that serries to not postpone
clean up things.
I think better is directly in that patch.
Maxim.
On Thu, Feb 18, 2016 at 6:41 AM, Maxim Uvarov
<maxim.uva...@linaro.org <mailto:maxim.uva...@linaro.org>
<mailto:maxim.uva...@linaro.org
<mailto:maxim.uva...@linaro.org>>> wrote:
On 02/18/16 05:03, Bill Fischofer wrote:
From: Barry Spinney <spin...@ezchip.com
<mailto:spin...@ezchip.com>
<mailto:spin...@ezchip.com <mailto:spin...@ezchip.com>>>
This patch adds a call from odp_init.c to
_odp_int_name_tbl_init().
Signed-off-by: Barry Spinney <spin...@ezchip.com
<mailto:spin...@ezchip.com>
<mailto:spin...@ezchip.com <mailto:spin...@ezchip.com>>>
Signed-off-by: Bill Fischofer
<bill.fischo...@linaro.org <mailto:bill.fischo...@linaro.org>
<mailto:bill.fischo...@linaro.org
<mailto:bill.fischo...@linaro.org>>>
---
platform/linux-generic/include/odp_internal.h | 3 ++-
platform/linux-generic/include/odp_timer_wheel_internal.h | 8
++++----
platform/linux-generic/odp_init.c | 1 +
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/platform/linux-generic/include/odp_internal.h
b/platform/linux-generic/include/odp_internal.h
index d7b71ca..991f33f 100644
--- a/platform/linux-generic/include/odp_internal.h
+++ b/platform/linux-generic/include/odp_internal.h
@@ -4,7 +4,6 @@
* SPDX-License-Identifier: BSD-3-Clause
*/
-
/**
* @file
*
@@ -107,6 +106,8 @@ int odp_time_term_global(void);
int odp_tm_init_global(void);
+void _odp_int_name_tbl_init(void);
+
void _odp_flush_caches(void);
int odp_cpuinfo_parser(FILE *file, odp_system_info_t
*sysinfo);
diff --git
a/platform/linux-generic/include/odp_timer_wheel_internal.h
b/platform/linux-generic/include/odp_timer_wheel_internal.h
index 0e5828f..54abb77 100644
---
a/platform/linux-generic/include/odp_timer_wheel_internal.h
+++
b/platform/linux-generic/include/odp_timer_wheel_internal.h
@@ -16,15 +16,15 @@ extern "C" {
#include <stdint.h>
#include <odp_api.h>
-/* Note that ALL times in this API are in units of
processor/cpu clock
- * cycles!
- */
typedef uint64_t _odp_timer_wheel_t;
#define _ODP_INT_TIMER_WHEEL_INVALID 0
_odp_timer_wheel_t _odp_timer_wheel_create(uint32_t
max_concurrent_timers,
- uint64_t current_time);
+ void *tm_system);
+
+void _odp_timer_wheel_start(_odp_timer_wheel_t
timer_wheel,
+ uint64_t current_time);
/* _odp_int_timer_wheel_curr_time_update should be
called
before the first
* call to _odp_int_timer_wheel_insert,
_odp_int_timer_wheel_next, etc..
diff --git a/platform/linux-generic/odp_init.c
b/platform/linux-generic/odp_init.c
index a8c91a5..fdc5981 100644
--- a/platform/linux-generic/odp_init.c
+++ b/platform/linux-generic/odp_init.c
@@ -96,6 +96,7 @@ int odp_init_global(const odp_init_t
*params,
return -1;
}
+ _odp_int_name_tbl_init();
return 0;
init_failed:
Does that apply now? We have stages and I do not see stage
line here.
_odp_int_name_tbl_init() has to be odp_tm_init_global()
and have
corresponding in odp_init_global().
I.e. the same thing as all other apis do.
Maxim.
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>>
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
