> -----Original Message----- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Wednesday, February 15, 2017 6:19 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v2 3/4] Revert "linux-generic: > packet: implement reference apis" > > On 02/15/17 15:29, Petri Savolainen wrote: > > This reverts commit 22b3986fea090986625f3255d57b64de35bbc475. > > --- > > sign-off is missing. Checkpatch should warn about that. > > Maxim.
This patch is output of the revert command as-is, and has couple of check patch warnings due to that. I can add sign-off there if that's needed, although I didn't do any modifications into the commit itself. Also 'make check' fails after this commit since the new implementation is added in the next commit. Anyway, I think this results cleaner git history as the revert is not modified (== not squashed with the new implementation). E.g. odp-dpdk can directly merge the new implementation, without the need to first merge the reverted one. -Petri
