Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

include/odp/api/spec/packet_flags.h
line 10
@@ -249,6 +249,14 @@ int odp_packet_has_ipsec(odp_packet_t pkt);
  */
 int odp_packet_has_udp(odp_packet_t pkt);
 
+/** Check for VxLAN
+ *
+ * @param pkt Packet handle
+ * @retval non-zero if packet contains VxLAN header
+ * @retval 0 if packet does not contain a VxLAN header
+ */
+int odp_packet_has_vxlan(odp_packet_t pkt);


Comment:
Inclusion of new APIs means this PR must be against api-next, not master.

> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> [RFC 7348](https://tools.ietf.org/html/rfc7348) uses VXLAN, not VxLAN. I 
> think we should use that throughout ODP as well as it avoids unnecessary 
> CamelCase.


>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Same comments here as for helper version of file.


>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>> Typo: reserve, not reseve? Perhaps better for these to be anonymous 
>>> bitfields if they are truly unreferenced?


https://github.com/Linaro/odp/pull/345#discussion_r157109346
updated_at 2017-12-15 02:13:15

Reply via email to