muvarov replied on github web page:
platform/linux-generic/include/protocols/vxlan.h
line 27
@@ -0,0 +1,56 @@
+/* Copyright (c) 2017, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+/**
+ * @file
+ *
+ * ODP VxLAN header
+ */
+
+#ifndef ODP_VXLAN_H_
+#define ODP_VXLAN_H_
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <odp_api.h>
+
+/** @addtogroup odp_header ODP HEADER
+ * @{
+ */
+
+/** VXLAN header length */
+#define _ODP_VXLANHDR_LEN 8
Comment:
`_ODPH_VXLAN_`
> muvarov wrote
> Please make name more common. ODPH_VXLAN_something everywhere.
>> Balasubramanian Manoharan(bala-manoharan) wrote:
>> Even if we add the capability currently we don't have ODP APIs expose them
>> as packet metadata functions. i.e odp_packet_has_inner_tcp()
>>
>> Should we add the capability and defer this to after tiger-moth?
>>> Balasubramanian Manoharan(bala-manoharan) wrote:
>>> Will migrate to api-next
>>>> Balasubramanian Manoharan(bala-manoharan) wrote:
>>>> Okay
>>>>> Balasubramanian Manoharan(bala-manoharan) wrote:
>>>>> Will change the typo.
>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>> The "TODO" can't stand by itself. Sounds like we need an additional
>>>>>> `odp_classification_capability()` bit to indicate whether inner packets
>>>>>> are included in the parse?
>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>> Typo: modified
>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>> Need to validate that the packet (and specified UDP length) is large
>>>>>>>> enough to contain the VXLAN header and the encapsulated packet.
>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>> Inclusion of new APIs means this PR must be against api-next, not
>>>>>>>>> master.
>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>> [RFC 7348](https://tools.ietf.org/html/rfc7348) uses VXLAN, not
>>>>>>>>>> VxLAN. I think we should use that throughout ODP as well as it
>>>>>>>>>> avoids unnecessary CamelCase.
>>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>>> Same comments here as for helper version of file.
>>>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>>>> Typo: reserve, not reseve? Perhaps better for these to be
>>>>>>>>>>>> anonymous bitfields if they are truly unreferenced?
https://github.com/Linaro/odp/pull/345#discussion_r157216345
updated_at 2017-12-15 14:44:48
