Balasubramanian Manoharan(bala-manoharan) replied on github web page: include/odp/api/spec/packet_flags.h line 4 @@ -249,6 +249,14 @@ int odp_packet_has_ipsec(odp_packet_t pkt); */ int odp_packet_has_udp(odp_packet_t pkt); +/** Check for VxLAN
Comment: Okay > Balasubramanian Manoharan(bala-manoharan) wrote: > Will change the typo. >> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >> The "TODO" can't stand by itself. Sounds like we need an additional >> `odp_classification_capability()` bit to indicate whether inner packets are >> included in the parse? >>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>> Typo: modified >>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>>> Need to validate that the packet (and specified UDP length) is large >>>> enough to contain the VXLAN header and the encapsulated packet. >>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>>>> Inclusion of new APIs means this PR must be against api-next, not master. >>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>>>>> [RFC 7348](https://tools.ietf.org/html/rfc7348) uses VXLAN, not VxLAN. I >>>>>> think we should use that throughout ODP as well as it avoids unnecessary >>>>>> CamelCase. >>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>>>>>> Same comments here as for helper version of file. >>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote: >>>>>>>> Typo: reserve, not reseve? Perhaps better for these to be anonymous >>>>>>>> bitfields if they are truly unreferenced? https://github.com/Linaro/odp/pull/345#discussion_r157151460 updated_at 2017-12-15 09:08:10
