Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/libodp-linux.pc.in
line 7
@@ -7,5 +7,5 @@ Name: libodp-linux
Description: The ODP packet processing engine
Version: @PKGCONFIG_VERSION@
Libs: -L${libdir} -lodp-linux
-Libs.private: @OPENSSL_STATIC_LIBS@ @DPDK_LIBS@ @PCAP_LIBS@ @PTHREAD_LIBS@
@TIMER_LIBS@ -lpthread @ATOMIC_LIBS@
-Cflags: -I${includedir}
+Libs.private: @OPENSSL_STATIC_LIBS@ @LIBCONFIG_STATIC_LIBS@ @DPDK_LIBS@
@PCAP_LIBS@ @PTHREAD_LIBS@ @TIMER_LIBS@ -lpthread @ATOMIC_LIBS@
+Cflags: -I${includedir} @LIBCONFIG_CPPFLAGS@
Comment:
OK, will fix.
> Matias Elo(matiaselo) wrote:
> I'm usually using multiple different NICs, so I find this information useful
> for logging test runs. Perhaps use ODP_PRINT() here?
>> Matias Elo(matiaselo) wrote:
>> Will fix.
>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>> Just use `PKG_CHECK_MODULES` here rather than inventing variables and
>>> checks.
>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Ideally we do not need this field. We should always return valid setting.
>>>> Maybe by allowing ODP modules to return default value.
>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>> I'd prefer not to export config internals here, but rather have
>>>>> `_odp_config_lookup_int()`, `_odp_config_lookup_string()`, etc.
>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>> Last line should not be necessary
>>>>>>> bogdanPricope wrote
>>>>>>> OFP is using a similar naming for the environment variable but with
>>>>>>> 'CONF' instead of 'CONFIG' ('OFP_CONF_FILE'). Will it makes sense to
>>>>>>> change the naming to avoid confusions: either 'ODP_CONF_FILE' in ODP or
>>>>>>> 'OFP_CONFIG_FILE' in OFP?
>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>> Do we really want to print this unconditionally? In any event
>>>>>>>> shouldn't this be `ODP_LOG()` here rather than `printf()`?
>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>> According to the [libconfig
>>>>>>>>> changelog](https://github.com/hyperrealm/libconfig/blob/master/ChangeLog)
>>>>>>>>> there are versions pre-1.0 (e.g., 0.9) which would fail this test.
>>>>>>>>> This needs to be reversed so that you use the newer form for v1.5 and
>>>>>>>>> higher levels:
>>>>>>>>> ```
>>>>>>>>> #if (LIBCONFIG_VER_MAJOR > 1 || (LIBCONFIG_VER_MAJOR == 1 &&
>>>>>>>>> LIBCONFIG_VER_MINOR >= 5)) ...
>>>>>>>>> ```
>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>> Does this have to be a hard dependency? Can we have this feature be
>>>>>>>>>> omitted (hardcoded defaults are used) if libconfig is not available?
https://github.com/Linaro/odp/pull/499#discussion_r170558253
updated_at 2018-02-26 11:06:52
