Matias Elo(matiaselo) replied on github web page:
m4/odp_libconfig.m4
line 7
@@ -0,0 +1,60 @@
+# ODP_LIBCONFIG([ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND])
+# -----------------------------------------------------
+AC_DEFUN([ODP_LIBCONFIG],
+[dnl
+AC_ARG_VAR([LIBCONFIG_CPPFLAGS], [C preprocessor flags for libconfig])
+AC_ARG_VAR([LIBCONFIG_LIBS], [linker flags for libconfig library])
+AC_ARG_VAR([LIBCONFIG_STATIC_LIBS], [static linker flags for libconfig
library])
Comment:
Not that familiar with autoconf, so I pretty much copy-pasted the
`odp_openssl.m4` to get this working. I'll take a look at `PKG_CHECK_MODULES `.
> Matias Elo(matiaselo) wrote:
> OK, will fix.
>> Matias Elo(matiaselo) wrote:
>> I'm usually using multiple different NICs, so I find this information useful
>> for logging test runs. Perhaps use ODP_PRINT() here?
>>> Matias Elo(matiaselo) wrote:
>>> Will fix.
>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Just use `PKG_CHECK_MODULES` here rather than inventing variables and
>>>> checks.
>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>> Ideally we do not need this field. We should always return valid setting.
>>>>> Maybe by allowing ODP modules to return default value.
>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>> I'd prefer not to export config internals here, but rather have
>>>>>> `_odp_config_lookup_int()`, `_odp_config_lookup_string()`, etc.
>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>> Last line should not be necessary
>>>>>>>> bogdanPricope wrote
>>>>>>>> OFP is using a similar naming for the environment variable but with
>>>>>>>> 'CONF' instead of 'CONFIG' ('OFP_CONF_FILE'). Will it makes sense to
>>>>>>>> change the naming to avoid confusions: either 'ODP_CONF_FILE' in ODP
>>>>>>>> or 'OFP_CONFIG_FILE' in OFP?
>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>> Do we really want to print this unconditionally? In any event
>>>>>>>>> shouldn't this be `ODP_LOG()` here rather than `printf()`?
>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>> According to the [libconfig
>>>>>>>>>> changelog](https://github.com/hyperrealm/libconfig/blob/master/ChangeLog)
>>>>>>>>>> there are versions pre-1.0 (e.g., 0.9) which would fail this test.
>>>>>>>>>> This needs to be reversed so that you use the newer form for v1.5
>>>>>>>>>> and higher levels:
>>>>>>>>>> ```
>>>>>>>>>> #if (LIBCONFIG_VER_MAJOR > 1 || (LIBCONFIG_VER_MAJOR == 1 &&
>>>>>>>>>> LIBCONFIG_VER_MINOR >= 5)) ...
>>>>>>>>>> ```
>>>>>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>>>>>> Does this have to be a hard dependency? Can we have this feature be
>>>>>>>>>>> omitted (hardcoded defaults are used) if libconfig is not available?
https://github.com/Linaro/odp/pull/499#discussion_r170559199
updated_at 2018-02-26 11:11:08
