Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

platform/linux-generic/odp_schedule_basic.c
@@ -720,9 +727,32 @@ static inline int poll_pktin(uint32_t qi)
 
                if (num_pktin == 0)
                        sched_cb_pktio_stop_finalize(pktio_index);
+
+               return num;
        }
 
-       return num;
+       if (atomic) {


Comment:
Is it really necessary to restrict this optimization to atomic queues? Ordered 
obviously cannot be stashed, but parallel queues make no ordering guarantees so 
accelerating them like this would also seem reasonable. In that case the 
`atomic` variable to this function would be better named something like 
`use_stash` .

> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Might be nice to say which interface wasn't started here for debug purposes 
> since many could be in play.


https://github.com/Linaro/odp/pull/504#discussion_r171691919
updated_at 2018-03-01 22:37:20

Reply via email to