Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

platform/linux-generic/odp_schedule_basic.c
@@ -805,17 +835,26 @@ static inline int do_schedule_grp(odp_queue_t *out_queue, 
odp_event_t out_ev[],
                                 * priorities. Stop scheduling queue when pktio
                                 * has been stopped. */
                                if (pktin) {
-                                       int num_pkt = poll_pktin(qi);
+                                       int atomic = queue_is_atomic(qi);


Comment:
If we relax this to cover atomic and parallel queues then this would simply be:
```
int use_stash = !queue_is_ordered(qi);
```

> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Is it really necessary to restrict this optimization to atomic queues? 
> Ordered obviously cannot be stashed, but parallel queues make no ordering 
> guarantees so accelerating them like this would also seem reasonable. In that 
> case the `atomic` variable to this function would be better named something 
> like `use_stash` .


>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Might be nice to say which interface wasn't started here for debug purposes 
>> since many could be in play.


https://github.com/Linaro/odp/pull/504#discussion_r171692278
updated_at 2018-03-01 22:37:20

Reply via email to