I will try to review and test these changes in the next couple of days. I have some stuff at work that needs attention. Just wanted to let you know if has not fallen through the crask too far.
-Mark > -----Original Message----- > From: Michael A. McAngus [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, July 17, 2002 7:54 PM > To: Log4J Developers List > Subject: Re: [SUBMIT] Timezone support for date elements of pattern > layout > > > Michael A. McAngus wrote: > > [EMAIL PROTECTED] wrote: > > > >> - "<li>Any pattern accpetible", should be "acceptible". > > > > > > Actually, should be "acceptable". I'll fix this and submit > a revised > > source tonight. > > ... > > >> AbsoluteDateFormat.java > ... > >> > >> - I don't see where AbsoluteTimeDateFormat(TimeZone) is > deprecated. It > >> appears to be gone. > >> > >> ----- > >> ISO8601DateFormat.java > >> > >> - I don't see where ISO8601DateFormat(TimeZone) is deprecated. It > >> appears > >> to be gone. > >> > >> ----- > >> DateTimeDateFormat.java > >> > >> - I don't see where DateTimeDateFormat(TimeZone) is > deprecated. It > >> appears > >> to be gone. > >> > > > > I really have no idea how that happened. I know I deprecated those > > methods. OK, I'll add them back and deprecate them. > > > >> ----- > >> PatternLayoutTestCase.java > >> > >> - I got the following message reported when the test case started: > >> > >> "D" is not a valid decimal seperator > >> Using Local defined decimal seperator > > > > > > Yep. That's a successful test :-) > > Or are you pointing out that "seperator" should be > "separator"? Another > > typo to fix. > > This is a LogLog.error message letting the user know that > there is a > > problem in the configuration file. > > > > ... > > >> ----- > >> AbsoluteTimeDateFormatTestCase.java > >> > >> - I get the following error reported when the test case starts: > >> > >> "X" is not a valid decimal seperator > >> etc > > > > > > Yep. Another successful test (except for "seperator"). > Negative tests > > are just as important as positive tests. > > > > Actually, the message says "separator", so no change was needed. > > > Fixes have been made, see the attached zip file containing updated > source and new diffs. > > -- > Cheers, > Mike McAngus > [EMAIL PROTECTED] > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
