OK, I finally got a chance to review this latest set of changes. I am fine
with them.
My only comment is that these changes were done against the 1.2 branch. As
such, after I have merged it into the current main branch, I get an error
for the ErrorHandlerTestCase, which does not exist in the main branch.
So, I am wondering if we should perform a merge of the 1.2 branch on to the
main branch before applying Mike's changes. We can still keep the 1.2
branch going after the merge?
-Mark
ErrorHandler:
[junit] Running org.apache.log4j.varia.ErrorHandlerTestCase
[junit] log4j:ERROR Could not open [input/xml/fallback1.xml].
[junit] java.io.FileNotFoundException: input/xml/fallback1.xml (The
system c
annot find the file specified)
[junit] at java.io.FileInputStream.open(Native Method)
[junit] at java.io.FileInputStream.<init>(FileInputStream.java:64)
[junit] at
org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigura
tor.java:583)
[junit] at
org.apache.log4j.xml.DOMConfigurator.configure(DOMConfigurato
r.java:694)
[junit] at
org.apache.log4j.varia.ErrorHandlerTestCase.test1(ErrorHandle
rTestCase.java:57)
[junit] at java.lang.reflect.Method.invoke(Native Method)
[junit] at junit.framework.TestCase.runTest(TestCase.java:166)
[junit] at junit.framework.TestCase.runBare(TestCase.java:140)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at
junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:131)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:173)
[junit] at junit.framework.TestSuite.run(TestSuite.java:168)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.
run(JUnitTestRunner.java:231)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.
main(JUnitTestRunner.java:409)
[junit] log4j:WARN No appenders could be found for logger (test).
[junit] log4j:WARN Please initialize the log4j system properly.
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.641 sec
[junit] Testsuite: org.apache.log4j.varia.ErrorHandlerTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.641 sec
[junit]
[junit] Testcase: test1 took 0.641 sec
> -----Original Message-----
> From: Michael A. McAngus [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 17, 2002 7:54 PM
> To: Log4J Developers List
> Subject: Re: [SUBMIT] Timezone support for date elements of pattern
> layout
>
>
> Michael A. McAngus wrote:
> > [EMAIL PROTECTED] wrote:
> >
> >> - "<li>Any pattern accpetible", should be "acceptible".
> >
> >
> > Actually, should be "acceptable". I'll fix this and submit a revised
> > source tonight.
>
> ...
>
> >> AbsoluteDateFormat.java
> ...
> >>
> >> - I don't see where AbsoluteTimeDateFormat(TimeZone) is deprecated. It
> >> appears to be gone.
> >>
> >> -----
> >> ISO8601DateFormat.java
> >>
> >> - I don't see where ISO8601DateFormat(TimeZone) is deprecated. It
> >> appears
> >> to be gone.
> >>
> >> -----
> >> DateTimeDateFormat.java
> >>
> >> - I don't see where DateTimeDateFormat(TimeZone) is deprecated. It
> >> appears
> >> to be gone.
> >>
> >
> > I really have no idea how that happened. I know I deprecated those
> > methods. OK, I'll add them back and deprecate them.
> >
> >> -----
> >> PatternLayoutTestCase.java
> >>
> >> - I got the following message reported when the test case started:
> >>
> >> "D" is not a valid decimal seperator
> >> Using Local defined decimal seperator
> >
> >
> > Yep. That's a successful test :-)
> > Or are you pointing out that "seperator" should be "separator"?
> Another
> > typo to fix.
> > This is a LogLog.error message letting the user know that there is a
> > problem in the configuration file.
> >
>
> ...
>
> >> -----
> >> AbsoluteTimeDateFormatTestCase.java
> >>
> >> - I get the following error reported when the test case starts:
> >>
> >> "X" is not a valid decimal seperator
> >> etc
> >
> >
> > Yep. Another successful test (except for "seperator"). Negative tests
> > are just as important as positive tests.
> >
>
> Actually, the message says "separator", so no change was needed.
>
>
> Fixes have been made, see the attached zip file containing updated
> source and new diffs.
>
> --
> Cheers,
> Mike McAngus
> [EMAIL PROTECTED]
>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
