On Feb 25, 2005, at 6:57 PM, Paul Smith wrote:
Appender the interface is the contract for all Appenders, AppenderSkeleton just happens to provide some decent plumbing and support in an effort to make it easy to write a custom appender.
Anywhere within log4j we should think Appender, and forget about the existence of AppenderSkeleton. Changing the contract of the interface should be done with extreme caution.
However, if changing the contract is for good reasons, then I am in favour of it, as long as we provide good documentation about "Why my custom appender doesn't work in 1.3" in big bold flashing lights.
Paul
At the present, I don't think the proposed changes to Appender are justified or beneficial. They are not used within log4j itself, they are only used within a new test case (AbstractAppenderTest) that could have been written in terms of AppenderSkeleton since it tests details of the AppenderSkeleton implementation that have not been part of the Appender contract.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
