Basically, the reason behind the remotehost and application properties in 1.3 is to provide the user with an easy way to distinguish between various event sources (running on one or more machines).
For the 'application' property, users COULD use rewriteappender & propertyrewritepolicy, but it's quite a bit of hassle for a single field that's frequently needed (and is not going to be an event property unless it's defined by the user). SocketReceiver already generates a 'log4j.remoteSourceInfo' property which contains the remote host and ephemeral port, which is too fine-grained (the remote host by itself is more useful than the remotehost + port). I'll take out remoteHost from socketappender and add the creation of the property in socketreceiver. I want to leave the 'application' property support in socketappender since it's only added if a user specifies the property. Scott Deboy -----Original Message----- From: Curt Arnold [mailto:[EMAIL PROTECTED] Sent: Thursday, August 23, 2007 9:46 AM To: Log4J Developers List Subject: Re: svn commit: r568980 - in /logging/log4j/trunk/src/main/java/org/apache/log4j: helpers/Constants.java net/SocketAppender.java On Aug 23, 2007, at 8:38 AM, [EMAIL PROTECTED] wrote: > Author: sdeboy > Date: Thu Aug 23 06:38:12 2007 > New Revision: 568980 > > URL: http://svn.apache.org/viewvc?rev=568980&view=rev > Log: > Moved Constants out of component & extras > Added application property & remote host now available as > properties via socketappender > Moving Constants into log4j doesn't help extras as it is intended to be used with earlier versions of log4j. I've eliminated the references to Constants in extras. I think the right place for Constants in in component since Constants is only provided to assist in supporting back-ported log4j 1.3 code. I'm not getting the SocketAppender change. First, anything on the log4j 1.2 branch needs to be committed against a bug report and changes.xml updated. What is the problem that is trying to be fixed or new capability added that this change is trying to address? It looks like you are trying to add additional properties into the serialized event and the change would be noticeable to any user of SocketAppender and would also show up in any other appender that consumed this event. This seems like too much of a surprise to add to log4j 1.2. Could you revert this change until we have the issues resolved? --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
