I'm going to add it to Log4j changes.xml instead of receivers changes.xml. Seems to belong in receivers, but that's empty. log4j changes looks like it contains everything (even socketappender-related).
Scott Deboy -----Original Message----- From: Curt Arnold [mailto:[EMAIL PROTECTED] Sent: Thursday, August 23, 2007 10:32 AM To: Log4J Developers List Subject: Re: svn commit: r568980 - in /logging/log4j/trunk/src/main/java/org/apache/log4j: helpers/Constants.java net/SocketAppender.java On Aug 23, 2007, at 12:02 PM, Scott Deboy wrote: > Basically, the reason behind the remotehost and application properties > in 1.3 is to provide the user with an easy way to distinguish between > various event sources (running on one or more machines). > > For the 'application' property, users COULD use rewriteappender & > propertyrewritepolicy, but it's quite a bit of hassle for a single > field > that's frequently needed (and is not going to be an event property > unless it's defined by the user). > > SocketReceiver already generates a 'log4j.remoteSourceInfo' property > which contains the remote host and ephemeral port, which is too > fine-grained (the remote host by itself is more useful than the > remotehost + port). > > I'll take out remoteHost from socketappender and add the creation > of the > property in socketreceiver. I want to leave the 'application' > property > support in socketappender since it's only added if a user specifies > the > property. > > > Scott Deboy > Works for me. I'd like to see: 1. File a bug report for back-porting the application property from log4j 1.3. 2. Add the change notice to src/changes/changes.xml 3. Make the changes to SocketReceiver and remove the reference to o.a.l.helpers.Constants. 4. Move o.a.l.helpers.Constants back to component. I don't think it should be in log4j 1.2 just for one string constant. It should be in component if needed for back-porting log4j 1.3 code. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
