Do these changes really accomplish anything? What is so magic about ""? It is pretty damn obvious what is going on.
Ralph On May 13, 2014, at 8:35 AM, ggreg...@apache.org wrote: > Author: ggregory > Date: Tue May 13 15:35:38 2014 > New Revision: 1594250 > > URL: http://svn.apache.org/r1594250 > Log: > Refactor magic strings into a constant. > > Modified: > > logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java > > Modified: > logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java > URL: > http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java?rev=1594250&r1=1594249&r2=1594250&view=diff > ============================================================================== > --- > logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java > (original) > +++ > logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java > Tue May 13 15:35:38 2014 > @@ -47,6 +47,7 @@ import org.apache.logging.log4j.core.hel > import org.apache.logging.log4j.core.helpers.Closer; > import org.apache.logging.log4j.core.helpers.FileUtils; > import org.apache.logging.log4j.status.StatusLogger; > +import org.apache.logging.log4j.util.Strings; > > /** > * Implementation of the {@code LoggerContextAdminMBean} interface. > @@ -113,7 +114,7 @@ public class LoggerContextAdmin extends > if (getConfigName() != null) { > return String.valueOf(new File(getConfigName()).toURI()); > } > - return ""; > + return Strings.EMPTY; > } > > @Override > > --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
