Shouldn't the diffs for file renames just have a list of files that were renamed and no content diffs?
On 14 May 2014 11:28, Ralph Goers <ralph.go...@dslextreme.com> wrote: > I have no problem in IntelliJ, but that is not the point. The point is to > bring these changes up before you do them and see if you have consensus, > not arbitrarily move stuff from one package to another or “fix” these kinds > of things. I am just getting tired of reviewing minor stuff like this in > the midst of a dozen other commits happening at almost the same time. And > it is really painful when the commit spreads over 4 emails because many > files were changed (and for some reason on one of them I never got the > first email which had the commit message in it). > > Ralph > > On May 14, 2014, at 9:04 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > I can't tell any of these apart on my phone without zooming in close! > > Same when I'm in Eclipse. I refuse to code in courier. Java is not cobol! > ;) > > Gary > > > -------- Original message -------- > From: Matt Sicker > Date:05/14/2014 11:59 (GMT-05:00) > To: Log4J Developers List > Subject: Re: svn commit: r1594250 - > /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java > > > I think it'd be important to make named constants for things like "'" or > '"' (wow those look impossible to read in sans-serif). For an empty string, > the "" is the constant. > > > On 14 May 2014 10:54, Ralph Goers <ralph.go...@dslextreme.com> wrote: > >> Any time your reason for a change ends with “IMO” I would recommend >> asking first. In this case it seems like hundreds of instances were >> changed, which would seem to me that the various people who did that >> thought differently than you. >> >> Ralph >> >> On May 14, 2014, at 6:34 AM, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> It's not always obvious, for example, when you see someVar = "" and >> otherVar = "'". Are they both right, does one have a typo? >> >> It's about communicating intent. Using a constant leaves no room for >> misinterpretation. >> >> Maybe readers that use a giant courier font "see" it differently, but the >> point of communicating intent still holds IMO. >> >> Gary >> >> >> On Wed, May 14, 2014 at 3:10 AM, Ralph Goers >> <ralph.go...@dslextreme.com>wrote: >> >>> Do these changes really accomplish anything? What is so magic about ""? >>> It is pretty damn obvious what is going on. >>> >>> Ralph >>> >>> On May 13, 2014, at 8:35 AM, ggreg...@apache.org wrote: >>> >>> > Author: ggregory >>> > Date: Tue May 13 15:35:38 2014 >>> > New Revision: 1594250 >>> > >>> > URL: http://svn.apache.org/r1594250 >>> > Log: >>> > Refactor magic strings into a constant. >>> > >>> > Modified: >>> > >>> >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java >>> > >>> > Modified: >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java >>> > URL: >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java?rev=1594250&r1=1594249&r2=1594250&view=diff >>> > >>> ============================================================================== >>> > --- >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java >>> (original) >>> > +++ >>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java >>> Tue May 13 15:35:38 2014 >>> > @@ -47,6 +47,7 @@ import org.apache.logging.log4j.core.hel >>> > import org.apache.logging.log4j.core.helpers.Closer; >>> > import org.apache.logging.log4j.core.helpers.FileUtils; >>> > import org.apache.logging.log4j.status.StatusLogger; >>> > +import org.apache.logging.log4j.util.Strings; >>> > >>> > /** >>> > * Implementation of the {@code LoggerContextAdminMBean} interface. >>> > @@ -113,7 +114,7 @@ public class LoggerContextAdmin extends >>> > if (getConfigName() != null) { >>> > return String.valueOf(new File(getConfigName()).toURI()); >>> > } >>> > - return ""; >>> > + return Strings.EMPTY; >>> > } >>> > >>> > @Override >>> > >>> > >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >>> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >>> >>> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second >> Edition<http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> >> > > > -- > Matt Sicker <boa...@gmail.com> > > > -- Matt Sicker <boa...@gmail.com>
