[ 
https://issues.apache.org/jira/browse/LOG4J2-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107568#comment-14107568
 ] 

Matt Sicker commented on LOG4J2-658:
------------------------------------

I still think the main idea to take from this is providing an SPI class 
(ShutdownRegistrationStrategy in this case) that containers and such can 
implement to hook into their own custom shutdown logic. That way it's easily 
extensible and all we really need to support is the standard Runtime method of 
doing so.

And shutdown hooks are run in sequence (not the Runtime ones, the system ones), 
each in a synchronization block. Then again, it's not like there's many threads 
(if any) to deal with at shutdown other than daemon threads.

> shutdown hook called too early
> ------------------------------
>
>                 Key: LOG4J2-658
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-658
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-rc1, 2.0-rc2, 2.0.2
>            Reporter: Romain Manni-Bucau
>            Assignee: Matt Sicker
>
> Hi
> this issue follow few mail exchanges from the commons list. Here the 
> interesting part for log4j2:
> {quote}
> Here what I do (we can move it to another thread since that's 100% log4j2 
> related): 
> unzip apache-tomee-1.7.0-SNAPSHOT-webprofile.zip && 
> cd apache-tomee-webprofile-1.7.0-SNAPSHOT/ && 
> rm conf/logging.properties  && 
> echo 'openejb.log.factory=log4j'>conf/system.properties && 
> cp ~/log4j2.xml conf/log4j2.xml && 
> cp 
> ~/.m2/repository/org/apache/logging/log4j/log4j-api/2.0-rc2-SNAPSHOT/log4j-api-2.0-rc2-SNAPSHOT.jar
>  lib/ && 
> cp 
> ~/.m2/repository/org/apache/logging/log4j/log4j-core/2.0-rc2-SNAPSHOT/log4j-core-2.0-rc2-SNAPSHOT.jar
>  lib/ && 
> cp 
> ~/.m2/repository/org/apache/logging/log4j/log4j-1.2-api/2.0-rc2-SNAPSHOT/log4j-1.2-api-2.0-rc2-SNAPSHOT.jar
>  lib/ && 
> ./bin/catalina.sh
> it makes server starting with log4j2 logs, if you ctrl+c logs are not 
> printed. Sure it is cause context is closed too early and then loggers have 
> NullConfiguration. (If I debug in java.lang.ApplicationShutdownHooks#runHooks 
> to wait all hooks exec it works)
> {quote}
> Basically the issue is that when shutting down with ctrl+C some logs are 
> swallowed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to