No problem! I looked at the commit emails, but I couldn't see if an equals() method was added to DynamicThresholdFilter. Without that method, the default Object.equals will fail the assert because the serialized-deserialized filter is a different instance from the original filter. Does the test work? (I may have missed something...)
Sent from my iPhone > On 2014/09/09, at 22:06, Gary Gregory <[email protected]> wrote: > > My bad, sorry :-( Fixed in git master. > > Gary > >> On Tue, Sep 9, 2014 at 2:41 AM, Remko Popma <[email protected]> wrote: >> DynamicalThresholdFilter does not implement equals(), so the >> AbstractSerializationTest.testSerializationRoundtrip fails. >> >> Sent from my iPhone >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
