Ah! I overlooked an email, now I see it. Please ignore my previous message.

On Wednesday, September 10, 2014, Remko Popma <[email protected]> wrote:

> No problem!
> I looked at the commit emails, but I couldn't see if an equals() method
> was added to DynamicThresholdFilter. Without that method, the default
> Object.equals will fail the assert because the serialized-deserialized
> filter is a different instance from the original filter. Does the test
> work? (I may have missed something...)
>
> Sent from my iPhone
>
> On 2014/09/09, at 22:06, Gary Gregory <[email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>
> My bad, sorry :-( Fixed in git master.
>
> Gary
>
> On Tue, Sep 9, 2014 at 2:41 AM, Remko Popma <[email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:
>
>> DynamicalThresholdFilter does not implement equals(), so the
>> AbstractSerializationTest.testSerializationRoundtrip fails.
>>
>> Sent from my iPhone
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> <javascript:_e(%7B%7D,'cvml','[email protected]');>
>> For additional commands, e-mail: [email protected]
>> <javascript:_e(%7B%7D,'cvml','[email protected]');>
>>
>>
>
>
> --
> E-Mail: [email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');> | [email protected]
> <javascript:_e(%7B%7D,'cvml','[email protected]');>
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>

Reply via email to