No objections here either. On Monday, September 14, 2015, Ralph Goers <[email protected]> wrote:
> Seems reasonable. > > Ralph > > On Sep 14, 2015, at 12:35 AM, Gary Gregory <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > > OK, I updated checkstyle with HidddenFields. > > Next, I'd like LineLength to be ignored for import statements. > > Thoughts? > > Gary > > On Fri, Sep 11, 2015 at 5:36 PM, Ralph Goers <[email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: > >> Actually, I am fine with setters that do that as well. Both can be >> configured to be OK with the HiddenField element. >> >> Ralph >> >> On Sep 11, 2015, at 5:22 PM, Gary Gregory <[email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote: >> >> Checkstyle complains about code like this: >> >> private final int foo; >> Ctor(int foo) { >> this.foo = foo; >> } >> >> Which is perfectly acceptable IMO. >> >> I really do not see the point of renaming all param names in a ctor. >> >> In a normal method, yes, you do not want to 'hide' an ivar with a pname. >> >> Gary >> >> -- >> E-Mail: [email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');> | >> [email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');> >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> >> > > > -- > E-Mail: [email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');> | [email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');> > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > >
