[
https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234176#comment-15234176
]
Gary Gregory commented on LOG4J2-1348:
--------------------------------------
Hi [~gdt],
Thank you for your new patch.
I'm really not a fan of the new method names here but I do not have a brilliant
better set of names. The least worst I can come up with is using, "with" as the
prefix, a prefix commonly used in fluent APIs: {{withPush}}, {{withPut}}. Using
"and" makes me think: "Should there be an "or"? Alternatives: {{pushValue}} and
{{putPair}}.
G
> Add an AutoCloseable ThreadContext class: CloseableThreadContext
> ----------------------------------------------------------------
>
> Key: LOG4J2-1348
> URL: https://issues.apache.org/jira/browse/LOG4J2-1348
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Reporter: Greg Thomas
> Assignee: Gary Gregory
> Priority: Minor
> Fix For: 2.6
>
> Attachments: CloseableThreadContext.zip, ctc.patch,
> thread-context.xml.patch
>
>
> The log4j2 API provides a ThreadContext -
> https://logging.apache.org/log4j/2.x/manual/thread-context.html - that
> allows items to be added to a stack or a map for logging, and then
> subsequently removed once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so
> that items are removed automatically and no longer left around littering the
> stack/map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
