[
https://issues.apache.org/jira/browse/LOG4J2-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244456#comment-15244456
]
Matt Sicker commented on LOG4J2-1348:
-------------------------------------
I also like the use of just push and put.
I've normally seen "with" used just like "get" and "set" as in the word or
words following it are usually nouns. So "withPut" sounds weird unless the
"put" is an object.
> Add an AutoCloseable ThreadContext class: CloseableThreadContext
> ----------------------------------------------------------------
>
> Key: LOG4J2-1348
> URL: https://issues.apache.org/jira/browse/LOG4J2-1348
> Project: Log4j 2
> Issue Type: Improvement
> Components: API
> Reporter: Greg Thomas
> Assignee: Gary Gregory
> Priority: Minor
> Fix For: 2.6
>
> Attachments: CloseableThreadContext.zip, ctc-also.patch, ctc.patch,
> thread-context.xml.patch
>
>
> The log4j2 API provides a ThreadContext -
> https://logging.apache.org/log4j/2.x/manual/thread-context.html - that
> allows items to be added to a stack or a map for logging, and then
> subsequently removed once they are no longer required.
> This sounds like an ideal candidate for a AutoCloseable implementation so
> that items are removed automatically and no longer left around littering the
> stack/map.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
