Gary, parameters from the logging call are now passed correctly to the appenders even in async scenarios.
I added an example to LOG4J2-1342 <https://issues.apache.org/jira/browse/LOG4J2-1342> of how to get the parameters when the Message is a ReusableMessage. The "normal" message.getParameters() method would create a copy of the array that is the exact length of the number of parameters, while with ReusableMessages there is a reused array of length 10 that is populated with the unrolled varargs... On Thu, Apr 21, 2016 at 7:59 AM, Gary Gregory <[email protected]> wrote: > I'll wait for the new CSV code before I investigate a GC-free version. > > Remko; no rush, I have plenty on my plate at work and elsewhere. > > Gary > > On Wed, Apr 20, 2016 at 2:03 PM, Remko Popma <[email protected]> > wrote: > >> I'm working on the last few remaining things for the LOG4J2-1270 >> <https://issues.apache.org/jira/browse/LOG4J2-1270> garbage-free epic >> that I want to include in 2.6: >> >> * Documentation LOG4J2-1297 >> <https://issues.apache.org/jira/browse/LOG4J2-1297> (todo: performance >> comparison) >> * making synchronous logging garbage-free: LOG4J2-1334 >> <https://issues.apache.org/jira/browse/LOG4J2-1334> (one broken unit >> test left) >> * passing message parameters down when logging async LOG4J2-1342 >> <https://issues.apache.org/jira/browse/LOG4J2-1342>. Needed for CSV >> layout. (initial implementation done, not committed yet, need to add unit >> tests) >> >> Of these the performance test results are most important. >> Latency/response time tests I still need to figure out how to do correctly. >> >> >> (Phew, almost there! That garbage-free thing was a boatload of work! Now >> I know why they call these things "epics"...) >> >> Sent from my iPhone >> >> On 2016/04/21, at 4:28, Matt Sicker <[email protected]> wrote: >> >> I, too, want to use the StackWalker API, but as it is currently, I don't >> see how we can use it without having some classes being compiled against >> Java 9. Reflection doesn't look like it'll work too well what with the >> lambdas unless we were targeting Java 8. >> >> On 20 April 2016 at 13:26, Ralph Goers <[email protected]> >> wrote: >> >>> I definitely want to leverage the StackWalker API. >>> >>> Someone recently requested that Logback be compliant with the compact3 >>> profile. I took a look and it wouldn’t be a big deal for us to meet that. >>> But I am more interested in what the new module system will look like. >>> >>> Ralph >>> >>> On Apr 20, 2016, at 10:50 AM, Gary Gregory <[email protected]> >>> wrote: >>> >>> Yeah, I do not think we need to do anything for JDK9 aside from maybe a >>> branch or a txt doc file with your findings. >>> >>> Gary >>> >>> On Wed, Apr 20, 2016 at 10:32 AM, Matt Sicker <[email protected]> wrote: >>> >>>> I have nothing in mind that's necessary for 2.6. I've started looking >>>> at some JDK9 stuff, but at the glacial rate JDK9 is being developed, we'll >>>> be several versions ahead before that's relevant. >>>> >>>> On 20 April 2016 at 12:20, Gary Gregory <[email protected]> wrote: >>>> >>>>> Hi Ralph, >>>>> >>>>> I wanted to see about getting the CSV layouts to play in the GC-free >>>>> world. Not critical though. I got some feedback from Remko on that, so I >>>>> think I know what to do... >>>>> >>>>> I'd also like to do a round of testing of the new flow logging APIs in >>>>> a branch for my work code base. This will make sure I've got most if not >>>>> all of my use cases covered. I can't do that today though. Maybe before >>>>> the >>>>> weekend. >>>>> >>>>> Gary >>>>> >>>>> On Wed, Apr 20, 2016 at 9:30 AM, Ralph Goers < >>>>> [email protected]> wrote: >>>>> >>>>>> I finally got a chance to fix the two bugs I wanted to get in for >>>>>> 2.6. I am thinking I should be able to do the release this weekend. Is >>>>>> there anything else that must be done before we can release? We have a >>>>>> lot >>>>>> of changes in 2.6 already. >>>>>> >>>>>> Ralph >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> E-Mail: [email protected] | [email protected] >>>>> Java Persistence with Hibernate, Second Edition >>>>> <http://www.manning.com/bauer3/> >>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>> Blog: http://garygregory.wordpress.com >>>>> Home: http://garygregory.com/ >>>>> Tweet! http://twitter.com/GaryGregory >>>>> >>>> >>>> >>>> >>>> -- >>>> Matt Sicker <[email protected]> >>>> >>> >>> >>> >>> -- >>> E-Mail: [email protected] | [email protected] >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >>> >>> >> >> >> -- >> Matt Sicker <[email protected]> >> >> > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory >
