[
https://issues.apache.org/jira/browse/LOG4J2-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390516#comment-15390516
]
ASF GitHub Bot commented on LOG4J2-1341:
----------------------------------------
Github user rzschech commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/34#discussion_r71966520
--- Diff: log4j-core/src/test/resources/log4j-style.xml ---
@@ -20,7 +20,7 @@
<Appenders>
<List name="List">
<PatternLayout>
- <Pattern>%d %highlight{%p} %style{%logger}{bright,cyan} %C{1.}
%msg%n</Pattern>
+ <Pattern>%d %highlight{%p}
%style{%logger}{bright,cyan}%style{}{bright,cyan} %C{1.} %msg%n</Pattern>
--- End diff --
This change is to verify that the no text appended within the style case.
> (GC) Avoid allocating temporary objects in Pattern Converters for
> PatternLayout
> -------------------------------------------------------------------------------
>
> Key: LOG4J2-1341
> URL: https://issues.apache.org/jira/browse/LOG4J2-1341
> Project: Log4j 2
> Issue Type: Improvement
> Components: Pattern Converters
> Affects Versions: 2.5
> Reporter: Remko Popma
> Fix For: 2.7
>
>
> *To do*
> The following pattern converters can be modified to avoid creating temporary
> objects in their {{format}} method:
> * AbstractStyleNameConverter
> * EncodingPatternConverter
> * EqualsIgnoreCaseReplacementConverter
> * EqualsReplacementConverter
> * FullLocationPatternConverter
> * HighlightConverter
> * IntegerPatternConverter
> * MarkerPatternConverter
> * MaxLengthConverter
> * RelativeTimePatternConverter
> * SequenceNumberPatternConverter
> * StyleConverter
> *Investigate*
> The following pattern converters may be difficult to modify since they rely
> on JDK components that create temporary objects:
> * ExtendedThrowablePatternConverter
> * MapPatternConverter
> * MdcPatternConverter
> * NdcPatternConverter
> * RegexReplacementConverter
> * RootThrowablePatternConverter
> * ThrowablePatternConverter
> * UuidPatternConverter
> * VariablesNotEmptyReplacementConverter
> *Done*
> The following pattern converters already do not allocate temporary objects in
> their format method:
> * ClassNamePatternConverter
> * DatePatternConverter
> * FileLocationPatternConverter
> * LevelPatternConverter
> * LineLocationPatternConverter
> * LineSeparatorPatternConverter
> * LiteralPatternConverter (unless literal contains '${')
> * LoggerPatternConverter
> * MarkerSimpleNamePatternConverter
> * MessagePatternConverter
> * MethodLocationPatternConverter
> * NamePatternConverter
> * NanoTimePatternConverter
> * ThreadIdPatternConverter
> * ThreadNamePatternConverter
> * ThreadPriorityPatternConverter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
