[ 
https://issues.apache.org/jira/browse/LOG4J2-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392437#comment-15392437
 ] 

ASF GitHub Bot commented on LOG4J2-1341:
----------------------------------------

GitHub user rzschech reopened a pull request:

    https://github.com/apache/logging-log4j2/pull/35

    LOG4J2-1341 Add support for period in ISO8601 format

    Add support for period in ISO8601 format as per the documentation: 
"millisecond separator may be either a comma ',' or a period '.'"
    
    Also Java's `java.time.Instant.toString()` and JavaScript's `new 
Date().toISOString()` use '.' as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rzschech/logging-log4j2 period

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 657b7d098eb75b6a4f04c56b0d6179f2fa9c14ae
Author: Richard Zschech <rich...@zschech.net>
Date:   2016-07-23T03:10:45Z

    LOG4J2-1341 Add support for period in ISO8601 format

----


> (GC) Avoid allocating temporary objects in Pattern Converters for 
> PatternLayout
> -------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1341
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1341
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Pattern Converters
>    Affects Versions: 2.5
>            Reporter: Remko Popma
>             Fix For: 2.7
>
>
> *To do*
> The following pattern converters can be modified to avoid creating temporary 
> objects in their {{format}} method:
> * AbstractStyleNameConverter
> * EncodingPatternConverter
> * EqualsIgnoreCaseReplacementConverter
> * EqualsReplacementConverter
> * FullLocationPatternConverter
> * HighlightConverter
> * IntegerPatternConverter
> * MarkerPatternConverter
> * MaxLengthConverter
> * RelativeTimePatternConverter
> * SequenceNumberPatternConverter
> * StyleConverter
> *Investigate*
> The following pattern converters may be difficult to modify since they rely 
> on JDK components that create temporary objects:
> * ExtendedThrowablePatternConverter
> * MapPatternConverter
> * MdcPatternConverter
> * NdcPatternConverter
> * RegexReplacementConverter
> * RootThrowablePatternConverter
> * ThrowablePatternConverter
> * UuidPatternConverter
> * VariablesNotEmptyReplacementConverter
> *Done*
> The following pattern converters already do not allocate temporary objects in 
> their format method:
> * ClassNamePatternConverter
> * DatePatternConverter
> * FileLocationPatternConverter
> * LevelPatternConverter
> * LineLocationPatternConverter
> * LineSeparatorPatternConverter
> * LiteralPatternConverter (unless literal contains '${')
> * LoggerPatternConverter
> * MarkerSimpleNamePatternConverter
> * MessagePatternConverter
> * MethodLocationPatternConverter
> * NamePatternConverter
> * NanoTimePatternConverter
> * ThreadIdPatternConverter
> * ThreadNamePatternConverter
> * ThreadPriorityPatternConverter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to