Hi Stefan, > The coming weekend - including the German holiday on Monday - is going > to be quite hectic (two birthdays in the family and a "Polterabend"[1] > in the neighborhood) for me. I don't expect to find time looking over > your code until next week. But I promise I'll do.
<OT> Don't forget the "böllern" (http://www.verlobung-hochzeit.de/hochzeits-brauch-tradition/brauch25-wecken-der-brautleute.php). In the end I'm kind of german, too. :-) Get the party on and see to it once you've got some free hours. </OT> Reviewing it all could become quite difficult since this is a huge patch. The most effective review method I know is mailing the patch and comment parts of it inline. For example: <example> + #region Protected Inner Classes + Don't forget the xml description + protected enum MatchType + { + Nothing, + Exact, + Remainder, + } + + #endregion </example> Do you wanna try that? Do you know something better suited that maybe is part of JIRA? :-) -- Dominik Psenner ## OpenPGP Key Signature ################################# # Key ID: B469318C # # Fingerprint: 558641995F7EC2D251354C3A49C7E3D1B469318C # ##########################################################
signature.asc
Description: OpenPGP digital signature
