Github user ahouben commented on the pull request:
https://github.com/apache/log4net/pull/12#issuecomment-77357942
Would it make sense to update the patch with the following modifications
then:
· Create a new top level src/log4net/log4net.vs2012.sln derived
from log4net.vs2010.sln with the following changes:
o targets .NET 4.5
o includes exactly the same sources as log4net.vs2010.sln
o defines an additional conditional compilation symbol
FRAMEWORK_4_5_OR_ABOVE which is used to conditionally execute the new unit
tests in the patch (Task.WhenAll used in the tests does not exist prior to .NET
4.5)
· Add a runtime check when accessing
LogicalThreadContext.{Stacks,Properties} which refuses to run is the underlying
.NET runtime is not at least 4.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
