[
https://issues.apache.org/jira/browse/LOG4NET-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859322#comment-15859322
]
Dominik Psenner commented on LOG4NET-553:
-----------------------------------------
I just reviewed your patch and it looks good! All these tests give me a good
feeling about your patch. However, there are things that need to be discussed
before we can continue:
1. Are the modifications in the TraceAppender required? The issue is unrelated
to that appender and therefore this patch should not modify it.
2. In the class DebugAppender you have added the line:
System.Diagnostics.Debug.Write(RenderLoggingEvent(loggingEvent),
m_category.Format(loggingEvent));
Should we pipe null into Debug.Write() if m_category happens to be null?
> DebugAppender configuration should give the possibility to disable outputting
> loggerName as category
> ----------------------------------------------------------------------------------------------------
>
> Key: LOG4NET-553
> URL: https://issues.apache.org/jira/browse/LOG4NET-553
> Project: Log4net
> Issue Type: New Feature
> Components: Appenders
> Affects Versions: 2.0.7
> Reporter: Jean-Francois Beaulac
> Attachments: log4net-DebugAppenderCategory.patch,
> OutputCategoryParam-DebugAppender.cs.patch
>
>
> The DebugAppender always uses the
> {{System.Diagnostics.Debug.Write(string,string)}} overload passing in the
> loggername as the category parameter.
> It should be possible to omit the category parameter if having the loggername
> as category is not desired.
> Attached is a patch implementing the desired new feature, which would be
> activated by configuration:
> {code:xml}
> <appender name="DEBUG" type="log4net.Appender.DebugAppender">
> <outputCategory value="false"/>
> <layout type="log4net.Layout.PatternLayout">
> <conversionPattern value="%-5level: %message%newline"/>
> </layout>
> </appender>
> {code}
> In my patch, the outputCategory parameter defaults to true, so the behavior
> doesnt change unless the new configuration is used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
