[
https://issues.apache.org/jira/browse/LOG4NET-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859761#comment-15859761
]
Jean-Francois Beaulac commented on LOG4NET-553:
-----------------------------------------------
1. No they are not required. I will remove them from the patch.
2. That makes sense, I always used log4net via XmlConfiguration so it didnt
cross my mind that one could programmatically set it to null.
I uploaded a new patch with the suggestions, I also added a test that checks
that the DebugAppender does not throw an exception if m_category is null and
correctly passes null to the Write() method.
> DebugAppender configuration should give the possibility to disable outputting
> loggerName as category
> ----------------------------------------------------------------------------------------------------
>
> Key: LOG4NET-553
> URL: https://issues.apache.org/jira/browse/LOG4NET-553
> Project: Log4net
> Issue Type: New Feature
> Components: Appenders
> Affects Versions: 2.0.7
> Reporter: Jean-Francois Beaulac
> Attachments: log4net-DebugAppenderCategory.patch,
> OutputCategoryParam-DebugAppender.cs.patch
>
>
> The DebugAppender always uses the
> {{System.Diagnostics.Debug.Write(string,string)}} overload passing in the
> loggername as the category parameter.
> It should be possible to omit the category parameter if having the loggername
> as category is not desired.
> Attached is a patch implementing the desired new feature, which would be
> activated by configuration:
> {code:xml}
> <appender name="DEBUG" type="log4net.Appender.DebugAppender">
> <outputCategory value="false"/>
> <layout type="log4net.Layout.PatternLayout">
> <conversionPattern value="%-5level: %message%newline"/>
> </layout>
> </appender>
> {code}
> In my patch, the outputCategory parameter defaults to true, so the behavior
> doesnt change unless the new configuration is used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
