Re: svn commit: r772512 - in /incubator/log4php/trunk/src: main/php/LoggerManager.php main/php/appenders/LoggerAppenderPDO.php test/php/appenders/LoggerAppenderPDOTest.php

[Christian Hammers]

Hello

I've not read the code completely but shouldn't there be a quote() or
something around the insert statement? Although this is just the
template, the single quote indicate at least that $sth->quote() is
not used.  

BTW, as you're aiming for speed, did you consider a PDO Prepared
Statement?

bye,

-christian-


Am Thu, 07 May 2009 06:29:31 -0000
schrieb grobme...@apache.org:

> Author: grobmeier
> Date: Thu May  7 06:29:28 2009
> New Revision: 772512
...
> +    public function activateOptions() {
...
> +        
> +        if($this->sql == '' || $this->sql == null) {
> +            $this->sql = "INSERT INTO $this->table ( timestamp, " .
> +
>                                                                               
> "logger,
> " .
> +
>                                                                               
> "level,
> " .
> +
>                                                                               
> "message,
> " .
> +
>                                                                               
> "thread,
> " .
> +
>                                                                               
> "file,
> " .
> +
>                                                                               
> "line" .
> +                                              ") VALUES
> ('%d','%c','%p','%m','%t','%F','%L')";
> +        }
> +