Hi Christian,

> I've not read the code completely but shouldn't there be a quote() or
> something around the insert statement? Although this is just the
> template, the single quote indicate at least that $sth->quote() is
> not used.

i am not sure what you mean with the above?

> BTW, as you're aiming for speed, did you consider a PDO Prepared
> Statement?

you are right, a PS would fit better in most cases. If you have some
cycles, I would apply all patches you bring in :-)

Cheers,
Christian

>
> bye,
>
> -christian-
>
>
> Am Thu, 07 May 2009 06:29:31 -0000
> schrieb [email protected]:
>
>> Author: grobmeier
>> Date: Thu May  7 06:29:28 2009
>> New Revision: 772512
> ...
>> +    public function activateOptions() {
> ...
>> +
>> +        if($this->sql == '' || $this->sql == null) {
>> +            $this->sql = "INSERT INTO $this->table ( timestamp, " .
>> +
>>                                                                              
>>  "logger,
>> " .
>> +
>>                                                                              
>>  "level,
>> " .
>> +
>>                                                                              
>>  "message,
>> " .
>> +
>>                                                                              
>>  "thread,
>> " .
>> +
>>                                                                              
>>  "file,
>> " .
>> +
>>                                                                              
>>  "line" .
>> +                                              ") VALUES
>> ('%d','%c','%p','%m','%t','%F','%L')";
>> +        }
>> +
>

Reply via email to